make the tests able to run on Node 12 - #572
Merged
Merged
Conversation
tests can run on Node 12
add cleanup
This was referenced Nov 7, 2019
thornjad
approved these changes
Nov 9, 2019
thornjad
left a comment
thornjad
left a comment
Member
There was a problem hiding this comment.
Love it, nice and clean. It's nice to have an explicit tear-down for something like a server which would reasonably continue running.
Contributor
Author
|
thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure that your pull request fulfills these requirements:
masterbranchWhat is the purpose of this pull request? (bug fix, enhancement, new feature,...)
make the tests run on Node 12
#569 (comment)
What changes did you make?
vowsto 0.8.3