Make get :: Get Char total#70
Merged
Merged
Conversation
The old Binary instance for Char used Data.Char.chr, which calls error if given an invalid code point. The instance is modified to call fail instead of error on invalid code points, which is total (within the Get Monad). Calls to error inside Get will escape decodeOrFail.
Contributor
|
Right, we can either do this fix to avoid using the partial |
kolmodin
added a commit
that referenced
this pull request
Feb 23, 2015
Make get :: Get Char total Fail within the Get monad for some UTF-8 errors
Member
Member
|
Submitted to hackage as 0.7.4.0. |
Member
There was a problem hiding this comment.
Please include the actual value so the user can debug their data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old Binary instance for Char used Data.Char.chr, which calls error
if given an invalid code point. The instance is modified to call fail
instead of error on invalid code points, which is total (within the Get
Monad). Calls to error inside Get will escape decodeOrFail.
This was discovered in
Cabal-1.22.0.0, because we lean pretty heavily onbinarynow.