Fix export for TypeScript#66
Conversation
Signed-off-by: MarkusRost <37275477+Markus-Rost@users.noreply.github.com>
|
Oh, were you the guy who tried to make a PR previous about typescript something? |
|
Is there a way we can... idk, lint or "test" that the types are working properly within the repository? Maybe setup something w/ TS? |
|
I made the PR adding index.d.ts originally. I'm sadly not very familiar with TypeScript myself, I'm mostly trying to make VSC happy 😅 |
|
But this time I at least tested the change properly :) Previous export was just the Got type, now it's an object of the type and matching what you are importing from got in index.js |
|
Hello, could you verify that this release works for you when you import from it? https://github.com/hanover-computing/got-ssrf/releases/tag/v1.3.5 |
|
Working for me (there were no code changes) and IDE is also happy about the typing of gotSsrf. I'm getting the same suggestions as just using plain got now so that should be fine as well. |
2 participants
Needs to export the default to work properly, my bad.
Didn't notice earlier because I forgot to test it before the release.