Skip to content

Accept abbreviated HalideTraceViz flags#9160

Open
Copilot wants to merge 3 commits into
mainfrom
copilot/fix-usage-message-flags
Open

Accept abbreviated HalideTraceViz flags#9160
Copilot wants to merge 3 commits into
mainfrom
copilot/fix-usage-message-flags

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 29, 2026

Description

The HalideTraceViz usage example used abbreviated flags (-s, -t) that were not actually accepted by argument parsing, so copying it directly produced an error.

This change updates HalideTraceViz to accept the abbreviated flags as synonyms for the existing long-form flags, and updates the usage text to document both forms.

  • Problem

    • The usage example and the actual CLI behavior were out of sync: the example used -s and -t, while parsing only accepted --size and --timestep.
  • Change

    • Accept -s as a synonym for --size.
    • Accept -t as a synonym for --timestep.
    • Update the example in util/HalideTraceViz.cpp to use the abbreviated flags again.
    • Update the usage text to document both the short and long forms.
    • Ensure --strides parsing still stops correctly when followed by -s or -t.
  • Example

    HalideTraceViz -s 1920 1080 -t 10000

Breaking changes

None.

Checklist

  • Tests added or updated (not required for docs, CI config, or typo fixes)
  • Documentation updated (if public API changed)
  • Python bindings updated (if public API changed)
  • Benchmarks are included here if the change is intended to affect performance.
  • Commits include AI attribution where applicable (see Code of Conduct)

Copilot AI changed the title [WIP] Fix usage message for HalideTraceViz flags Fix HalideTraceViz usage example flags May 29, 2026
Copilot AI requested a review from alexreinking May 29, 2026 15:29
@alexreinking
Copy link
Copy Markdown
Member

@copilot - the goal was to accept the abbreviated flags as synonyms of the longer flags.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 29, 2026

@copilot - the goal was to accept the abbreviated flags as synonyms of the longer flags.

Addressed in 973a91e.

Copilot AI changed the title Fix HalideTraceViz usage example flags Accept abbreviated HalideTraceViz flags May 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@7e2ecf2). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9160   +/-   ##
=======================================
  Coverage        ?   69.37%           
=======================================
  Files           ?      254           
  Lines           ?    78216           
  Branches        ?    18712           
=======================================
  Hits            ?    54259           
  Misses          ?    18479           
  Partials        ?     5478           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexreinking alexreinking marked this pull request as ready for review May 29, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Example in usage message for HalideTraceViz uses nonexistent flags (-s and -t in lieu of --size and --timestamp)

2 participants