Accept abbreviated HalideTraceViz flags#9160
Open
Copilot wants to merge 3 commits into
Open
Conversation
Copilot
AI
changed the title
[WIP] Fix usage message for HalideTraceViz flags
Fix HalideTraceViz usage example flags
May 29, 2026
Member
|
@copilot - the goal was to accept the abbreviated flags as synonyms of the longer flags. |
Contributor
Author
Copilot
AI
changed the title
Fix HalideTraceViz usage example flags
Accept abbreviated HalideTraceViz flags
May 29, 2026
alexreinking
approved these changes
May 29, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9160 +/- ##
=======================================
Coverage ? 69.37%
=======================================
Files ? 254
Lines ? 78216
Branches ? 18712
=======================================
Hits ? 54259
Misses ? 18479
Partials ? 5478 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexreinking
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
HalideTraceVizusage example used abbreviated flags (-s,-t) that were not actually accepted by argument parsing, so copying it directly produced an error.This change updates
HalideTraceVizto accept the abbreviated flags as synonyms for the existing long-form flags, and updates the usage text to document both forms.Problem
-sand-t, while parsing only accepted--sizeand--timestep.Change
-sas a synonym for--size.-tas a synonym for--timestep.util/HalideTraceViz.cppto use the abbreviated flags again.--stridesparsing still stops correctly when followed by-sor-t.Example
Breaking changes
None.
Checklist