Enable 4-day automated backups on incubator-prod-database - #151
Merged
Conversation
Contributor
|
Terraform plan in terraform Plan: 0 to add, 1 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
Terraform will perform the following actions:
# aws_db_instance.default will be updated in-place
!~ resource "aws_db_instance" "default" {
!~ backup_retention_period = 0 -> 4
id = "db-WEFHC5MZIA5NX5PBTQZPC2STZQ"
tags = {
"Name" = "incubator-prod-database"
"terraform_managed" = "true"
}
# (72 unchanged attributes hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.✅ Plan applied in Terraform apply (OIDC) #59 |
ale210
marked this pull request as ready for review
August 10, 2026 23:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
backup_retention_periodto 4 onincubator-prod-database, which currently runs with no automated backups and no snapshots.Closes #149
Draft on purpose — do not merge until an outage window is scheduled
Merging this PR is the deploy.
terraform-apply.yamlrunsterraform applywithauto_approve: trueon every push tomaintouching a.tffile, and the instance hasapply_immediately = true.Changing backup retention from 0 to a non-zero value restarts the RDS instance. This is not a zero-downtime change, and all six projects share this one instance (vrms, civic-tech-index, civic-tech-jobs, home-unite-us, people-depot, access-the-data). Mark ready for review only once the window is booked and announced.
Before merging, check the plan
The
terraform-planoutput must show an in-place update toaws_db_instance.defaultand nothing else. A plan proposing to replace this resource must not be merged —skip_final_snapshot = trueanddeletion_protection = falsemean nothing would stop a destroy.Cost
No cost increase. The database holds ~5.8 GiB against a free backup-storage allowance equal to its 100 GiB of allocated storage, so projected backup storage (~13 GiB including the planned manual snapshot) stays well inside the free tier.
After merging
Post-merge steps are on #149: verify retention reads
4, take theincubator-prod-database-pre-pg15manual snapshot, confirm it reachesavailable, and check the ECS services inincubator-prodreconnected.