Skip to content

Add contributing md 120 - #126

Merged
chelseyklein merged 11 commits into
hackforla:masterfrom
angela-lee1:add-contributing-md-120
Apr 18, 2024
Merged

Add contributing md 120#126
chelseyklein merged 11 commits into
hackforla:masterfrom
angela-lee1:add-contributing-md-120

Conversation

@angela-lee1

@angela-lee1 angela-lee1 commented Mar 27, 2024

Copy link
Copy Markdown
Member

Fixes #120
Added a contributing markdown file to provide clear instructions for new contributors. Added instructions for making contributions to the repo: forking repo, cloning repo, creating a new branch, adding committing, pushing changes, and creating a pull request.

@angela-lee1

Copy link
Copy Markdown
Member Author

@chelseybeck @nyarly Please take a look at it, and make any suggestions for revision. Thank you

Comment thread CONTRIBUTING.md Outdated

### **Working on an issue**

For each issue you address, create a new branch. Working on topic branches ensures that your main branch(named `master`)remains untouched and makes it easier to synchronize your fork with the main project.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For each issue you address, create a new branch. Working on topic branches ensures that your main branch(named `master`)remains untouched and makes it easier to synchronize your fork with the main project.
For each issue you address, create a new branch. Working on topic branches ensures that your main branch(named `main`)remains untouched and makes it easier to synchronize your fork with the main project.

Comment thread CONTRIBUTING.md Outdated

For each issue you address, create a new branch. Working on topic branches ensures that your main branch(named `master`)remains untouched and makes it easier to synchronize your fork with the main project.

#### **Working on an issue (1): Verify current branch is `master`**

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### **Working on an issue (1): Verify current branch is `master`**
#### **Working on an issue (1): Verify current branch is `main`**

Comment thread CONTRIBUTING.md Outdated

#### **Working on an issue (1): Verify current branch is `master`**

first make sure you are on the master branch.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
first make sure you are on the master branch.
first make sure you are on the main branch.

Comment thread CONTRIBUTING.md Outdated
first make sure you are on the master branch.

```bash
git checkout master

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
git checkout master
git checkout main

Comment thread CONTRIBUTING.md Outdated
git checkout master
```

Update your master branch with the latest changes

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Update your master branch with the latest changes
Update your main branch with the latest changes

Comment thread CONTRIBUTING.md Outdated
Update your master branch with the latest changes

```
git pull upstream master

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
git pull upstream master
git pull upstream main

Comment thread CONTRIBUTING.md Outdated
After committing your changes locally, you can use below commands to push your committed changes to a remote repository, making them accessible to others working on the same projects.

```bash
git push --set-upstream add-contributing-md-120

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
git push --set-upstream add-contributing-md-120
git push --set-upstream origin add-contributing-md-120

@chelseyklein

Copy link
Copy Markdown
Member

@awlFCCamp I recommended a few changes. GitHub used to default to naming branches 'master', but switched to 'main'. Newer repos (like ours) use 'main'. Other than that, this looks great! Thanks for working on it 😄

@angela-lee1

Copy link
Copy Markdown
Member Author

@chelseybeck I made changes. Please take a look at it, and make any suggestions for revision. Thank you.

@abbyz123 abbyz123 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you so much for your work!

@chelseyklein
chelseyklein merged commit 712b3e8 into hackforla:master Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a CONTRIBUTING.md to the Ops repo

3 participants