test(node-adapters): run fetch(nodeHandler) suite on Deno and Bun in CI - #272
Merged
Conversation
Runs test/node-adapters.test.ts (the `fetchNodeHandler` / node-handler
suite) against Bun and Deno, alongside the existing Node coverage.
- Bun: passes fully; added to the `tests_bun` job.
- Deno: skip 7 known failures on Deno (keep-alive body-read poisoning and
a couple of streaming/error paths in Deno's node-compat HTTP layer that
pass on Node and Bun). The in-process `direct fetch` variants still run.
- The suite needs a newer Deno than the pinned `tests_deno` node-compat
job (passes on latest v2, fails broadly on 2.7.12), so it runs in its own
`tests_deno_node_adapters` job on unpinned latest Deno v2 to avoid forcing
a version bump on `tests_deno`.
- Add `test:node-adapters:{deno,bun}` scripts mirroring `test:node-compat:*`.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughChangesNode adapter runtime testing
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
pi0
reviewed
Jul 17, 2026
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #132
What
Runs
test/node-adapters.test.ts— thefetchNodeHandler/ node-handler suite (fetch(nodeHandler)) — against Bun and Deno in CI, alongside the existing Node coverage.Results by runtime
node-adapters.test.tsChanges
Bun: added
bun run test:node-adapters:bunto thetests_bunjob — full pass, no skips.Deno: skip 7 known failures on Deno (guarded by an
isDenoconst, each with a comment):fetchNodeHandler > {node,express,fastify} > through srvx/nodevariants (over a real socket),streaming the body directly…andcancelling req.body…(body-crash regressions),send error is logged…/send error is not logged…(fetch-spec regressions).These trip Deno's node-compat HTTP layer (keep-alive body-read poisoning + a couple of streaming/error paths); they pass on Node and Bun. The in-process
direct fetchvariants still run on Deno.Added
test:node-adapters:{deno,bun}scripts mirroringtest:node-compat:*.Why a separate Deno job
The two Deno suites need opposite versions:
node.test.ts(node-compat)node-adapters.test.tsBumping the shared pin to latest v2 would regress the currently-green
node.test.tsjob (exactly what the pin comment protects against). So node-adapters runs in its owntests_deno_node_adaptersjob on unpinned latest Deno v2, leavingtests_denountouched. Wired into both publishneedsarrays.🤖 Generated with Claude Code
Summary by CodeRabbit