docs: improvements - #238
Conversation
Docs scope of the v1 stabilization plan (F54, F14, F53, F11, F55, F56, CLI, support matrix, skipped-test issue links). - server.md: delete non-existent `server.addr` / `server.port` sections and the stale `#port-required` anchor (F54); fix "Bun instance in Deno" copy-paste error. - handler.md: `request.runtime.node?.req.path` -> `.url` (F54). - options.md: `maxHeadersize` -> `maxHeaderSize`; document `hostname` HOST env default (F14); document `manual`, `middleware`, `plugins`, `serviceWorker`; add per-runtime support matrix (close(true) on Deno, trustProxy scope, Bun 128 MiB / loader-drop for maxRequestBodySize, manual on workers, Cloudflare env in SW syntax, no upgrade/WebSocket -> crossws); Deno 2.x range + explicit `srvx/bunny` import note; public subpaths table; per-runtime `@types` note (F56); note `srvx/static` is Node-API-only. - node.md: state `_request`/`_url` are supported API frozen at v1 (D7/F53); `toFetchHandler`/`fetchNodeHandler` stable, `srvx/tracing` experimental (D5/F11); add Semver policy section incl. ERR_BODY_TOO_LARGE-only code guarantee (F55). - cli: `usage.ts` env wording (default, not override), document `--hostname`, fetch `--host`/`--tls`, `--method` (+`--request` alias), exit-22 line; cli.md precedence, exit-code divergence from curl, and Deno `--import` drop. - types.ts: fix "server with listen" JSDoc typo + HOST default (F14). - Link skipped protocol tests to tracking issues (#235, #236, #237). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 41 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe CLI help text and guides were updated to document current fetch, host, static-serving, loader, middleware, adapter, runtime, and API behavior. Documentation corrections also clarify public Node APIs, server properties, runtime examples, semver guarantees, and tracked HTTP/2/TLS test gaps. ChangesCLI and server-entry loading
Middleware and adapter options
Runtime APIs and documentation corrections
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/1.guide/10.cli.md`:
- Around line 139-145: Update the loadServerEntry example to handle both missing
entries and entries whose fetch handler is undefined. Add a guard for
loaded.fetch before calling serve, or change the example to use a server entry
guaranteed to export a supported handler, and remove the non-null assertion from
serve.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d500ea0c-d5aa-470c-83c8-edf3f0141c1d
📒 Files selected for processing (10)
docs/1.guide/10.cli.mddocs/1.guide/2.handler.mddocs/1.guide/3.server.mddocs/1.guide/4.middleware.mddocs/1.guide/5.options.mddocs/1.guide/8.node.mdsrc/cli/usage.tssrc/types.tstest/_tests.tstest/node.test.ts
Docs scope of the v1 stabilization plan. Every technical claim was verified against the code. Does not touch
trustProxydocs (PR #229), the### error/gracefulShutdownrewrites (PR #230),@experimentalcode removals (PR #230), or9.aws-lambda.md(AWS agent, F23).T1 — docs promising APIs that don't exist
server.addrandserver.portsections from3.server.md(neither exists; onlyserver.url) plus the stale#port-requiredanchor.T2 — wrong / missing docs
2.handler.mdreq.path→req.url;3.server.md"underlying Bun server instance when running in Deno" → Deno;5.options.mdmaxHeadersize→maxHeaderSize.manual,middleware,plugins,serviceWorkerin5.options.md(lefterror/gracefulShutdownto feat: v1 api freeze #230).srvx/static,srvx/log,srvx/loader,srvx/cli,srvx/generic,srvx/service-worker.hostname ← HOSTandsilent ← TESTenv defaults; fixed thetypes.ts"server with listen" JSDoc typo.close(true)ignored on Deno,trustProxyadapter scope,maxRequestBodySize(Bun 128 MiB / dropped in loader mode — F57),manualno-op on module workers, Cloudflareenvonly in module syntax (F29), and noupgrade/WebSocket on any runtime → crossws (locked).srvx/staticis Node-API-only (node:fs/node:zlib) — noted in10.cli.mdand the subpaths table.srvx/bunnyimport (root resolves thedenocondition).T3
_request/_urldocumented as supported API frozen at v1 (underscore is legacy naming).toFetchHandler/fetchNodeHandlerdocumented stable;srvx/tracingdocumented experimental — plus a new Semver policy section (also states F55:ERR_BODY_TOO_LARGEis the only guaranteed errorcode).@typespackages (@types/bun,@types/deno,@cloudflare/workers-types,@types/aws-lambda) documented for full typing ofoptions.bun/runtime.cloudflare/etc.srvx fetchnon-2xx → exit 22 documented prominently (diverges from curl).usage.tsfixes: env wording "default" not "override", document--hostname, fetch--host/--tls,--method(+--requestalias), exit-22 line;10.cli.mdprecedence (flag > module > env > default) and Deno--importdrop.Verification
pnpm lint:fix(automd regenerated the CLI usage block),pnpm typecheck, and the common + CLI vitest suites all pass (914 passed / 32 pre-existing skips). Deno/Bun-only suites not run locally (no runtimes installed; CI covers them).🤖 Generated with Claude Code
Summary by CodeRabbit