Make less-builder compatible with less v2 - #79
Open
jcppman wants to merge 1 commit into
Open
Conversation
|
I spent several hours debugging until I saw this PR. Thank you from the bottom of my heart. |
jcppman
force-pushed
the
master
branch
2 times, most recently
from
August 31, 2015 09:10
70b1216 to
977eca4
Compare
|
@jcppman u still available for this module also? Could u verify latest master in regards to your branch, and squash commits. I may be reviewing this module also. Not sure yet. |
jcppman
force-pushed
the
master
branch
2 times, most recently
from
February 27, 2017 13:00
d1a8fa5 to
5fb7003
Compare
- detect less major version by less.version[0] - assign different functions to renderer and cssGetter - generate css as before by evaluating rederer and cssGetter
Contributor
Author
|
squashed! and the path fixing part is separated into another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this PR is for making
r.jsoptimizer works in both less v2 and less v1 by modifying the flow oflessAPI.loadinless-builder.jswith following changes:The tests on my computer are passed.
I think this is slightly more emergent because while building the whole package with
r.jsoptimizer,less-builder.jsuse globallessinstallation and it might not be a very easy job to control version of it or downgrade it on production environment.Hope this PR is useful for other ppl!