Default STANDINGS_LABEL to a dedicated authgd label - #8
Merged
Conversation
The contacts job owns its label outright: every contact carrying it that is not a current FlyGD member is deleted (src/core/contacts-diff.ts). Defaulting to the corp's own label pointed that behaviour at a list humans curate by hand — on the first production run it deleted 130 contacts that had been under the pre-existing label. Default to "authgd" instead, so a fresh setup names a label created for the app rather than one already in use, and document the hazard next to the env table along with the three properties that make the switch safe: ESI cannot create labels (a missing one skips all writes), the match is exact and case-sensitive (a typo skips rather than deletes), and nothing about the label is persisted (the id is resolved per run, so changing it needs no migration). Config-only; deployed environments set STANDINGS_LABEL explicitly.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe default ChangesStandings label configuration
Estimated code review effort: 1 (Trivial) | ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The contacts job owns
STANDINGS_LABELoutright — every contact carrying that label that isn't a current FlyGD member is deleted (src/core/contacts-diff.ts:46-48). Defaulting to the corp's own label aimed that at a list people curate by hand. On the first production run it deleted 130 contacts that were already under the pre-existing label.What changed
src/config.ts— defaultFLYGD→authgd, with the ownership hazard in the comment.docs/ops.md— new "Contact label — use a dedicated one" section; env-table row points at it..env.example,docs/ops.mdsecrets snippet — updated to match.The docs call out the three properties that make changing this safe:
missing_labeland skips every write.Scope
Config and docs only. No schema, no migration, no job logic. Deployed environments set
STANDINGS_LABELexplicitly, so the default change affects fresh setups only — production is switched separately viafly secrets set, after the label exists in-game.Verification
🤖 Generated with Claude Code
Summary by CodeRabbit
Configuration
authgd.Documentation