Skip to content

Default STANDINGS_LABEL to a dedicated authgd label - #8

Merged
guarzo merged 1 commit into
mainfrom
worktree-standings-label-authgd
Aug 3, 2026
Merged

Default STANDINGS_LABEL to a dedicated authgd label#8
guarzo merged 1 commit into
mainfrom
worktree-standings-label-authgd

Conversation

@guarzo

@guarzo guarzo commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Why

The contacts job owns STANDINGS_LABEL outright — every contact carrying that label that isn't a current FlyGD member is deleted (src/core/contacts-diff.ts:46-48). Defaulting to the corp's own label aimed that at a list people curate by hand. On the first production run it deleted 130 contacts that were already under the pre-existing label.

What changed

  • src/config.ts — default FLYGDauthgd, with the ownership hazard in the comment.
  • docs/ops.md — new "Contact label — use a dedicated one" section; env-table row points at it.
  • .env.example, docs/ops.md secrets snippet — updated to match.

The docs call out the three properties that make changing this safe:

  • ESI cannot create labels — a missing one records missing_label and skips every write.
  • The match is exact and case-sensitive — a typo skips rather than deletes.
  • Nothing about the label is persisted (the id is resolved per run) — no migration; old-label contacts just become unmanaged.

Scope

Config and docs only. No schema, no migration, no job logic. Deployed environments set STANDINGS_LABEL explicitly, so the default change affects fresh setups only — production is switched separately via fly secrets set, after the label exists in-game.

Verification

> tsc --noEmit
(clean)

Test Files  39 passed (39)
     Tests  271 passed (271)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Configuration

    • Updated the default standings/contact label to authgd.
  • Documentation

    • Clarified label ownership, case-sensitive matching, missing-label behavior, and the impact of changing the configured label.
    • Updated deployment and environment setup guidance to use the new default.

The contacts job owns its label outright: every contact carrying it that is
not a current FlyGD member is deleted (src/core/contacts-diff.ts). Defaulting
to the corp's own label pointed that behaviour at a list humans curate by
hand — on the first production run it deleted 130 contacts that had been
under the pre-existing label.

Default to "authgd" instead, so a fresh setup names a label created for the
app rather than one already in use, and document the hazard next to the env
table along with the three properties that make the switch safe: ESI cannot
create labels (a missing one skips all writes), the match is exact and
case-sensitive (a typo skips rather than deletes), and nothing about the
label is persisted (the id is resolved per run, so changing it needs no
migration).

Config-only; deployed environments set STANDINGS_LABEL explicitly.
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: cfaa67dd-3095-4fdb-95d9-0febf689eef1

📥 Commits

Reviewing files that changed from the base of the PR and between dd78815 and 420b2cc.

📒 Files selected for processing (3)
  • .env.example
  • docs/ops.md
  • src/config.ts

📝 Walkthrough

Walkthrough

The default STANDINGS_LABEL changes from FLYGD to authgd. The environment example and operations documentation use the new value and describe label ownership, exact matching, missing-label behavior, and effects of changing the label.

Changes

Standings label configuration

Layer / File(s) Summary
Update the standings label default and guidance
.env.example, src/config.ts, docs/ops.md
The default and deployment example use authgd. Configuration comments and operations documentation define the label as app-owned and case-sensitive, and document behavior for missing or changed labels.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Poem

A rabbit changed the label with care,
From FLYGD to authgd in the air.
Exact case now guides the way,
Old contacts wait where they stay.
Config and docs hop into place.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the primary change to use a dedicated authgd value for STANDINGS_LABEL.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch worktree-standings-label-authgd
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch worktree-standings-label-authgd

Comment @coderabbitai help to get the list of available commands.

@guarzo
guarzo merged commit 8cf303a into main Aug 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant