docs: improve authGD discoverability and licensing - #156
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 31 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (5)
Comment |
main moved under this run: #150, #152, #153 and #156 merged while the sweep was working, and #153 landed in `confirm-submit.tsx`, which round one had rewritten. GitHub reported #148 CONFLICTING/DIRTY. The conflict was two independent edits to one file, resolved by keeping both rather than choosing: - Round one replaced the `ch`-arithmetic width reservation with CSS generated content (`data-ghost-label`). #153's docblock paragraph describing the old `ch` reservation is superseded and dropped, along with its `widthCh` constant, which nothing renders any more. - #153 added the `confirm` prop, the below-the-hooks throw, and the `confirm && ctx?.armedId === id` arming test, all of which are about component-type stability in the pay flow and untouched by round one. Kept verbatim, comments included. Verified rather than assumed: #153's own regression spec — "a second row's mark paid button survives the first payment's arm-to-plain transition" (`e2e/payouts.spec.ts:2212`) — passes on the merge.
1 participant
Documentation, licensing, and repository-metadata pass. No application behavior changes — no TypeScript, CSS, migrations, tests, or runtime configuration in the diff, and
public/is byte-identical, so the running site's imagery is untouched.What changed
README.mdLICENSEARTWORK-LICENSE.mdpublic/brand/*.webpfiles, credit-required terms unchangedNOTICE.md.github/SECURITY.mddocs/assets/authgd-hero.svg<title>/<desc>for screen readersdocs/assets/authgd-social-preview.pngdocs/assets/hero.pngThe license split is the point: keeping
LICENSEas unmodified MIT should let GitHub's detector report MIT instead ofother, while the artwork permission and CCP notice survive intact in their own files.Corrections made against the code
Several statements in the previous README were stale or wrong, and were fixed against source rather than carried forward:
src/core/schedules.ts:10-17).APP_BASE_URLno longer warns about trailing slashes —src/config.ts:30-36normalizes to origin plus path and strips them.LICENSEclaimed all ofpublic/was Faoble's work.public/brand/holds five tracked files; the fifth is CCP's EVE SSO login button used atsrc/app/login/page.tsx:175. It is now covered byNOTICE.md, with a cross-reference fromARTWORK-LICENSE.md.src/core/contact-label.ts:38-45).memberat any status, so a cryo account still sees history; creating and editing require an active member account (src/services/payouts.ts:42-50).CONTRIBUTING.mdlinksREADME.md#quickstart-local-developmentand#making-it-yours, so both headings were kept verbatim.Repository metadata
Already applied out-of-band and verified: a description, 19 topics, private vulnerability reporting enabled, and the social preview uploaded. Homepage deliberately left empty — there is no distinct public project site.
Verification
npm testnpm run test:e2enpm run builddocker build .npm run typecheck/lint/format:checkscripts/check-node-version.shDockerfile=24 .nvmrc=24 engines='>=24'Every relative link and heading anchor in the new and edited files was checked to resolve, including the two inbound anchors from
CONTRIBUTING.md.Review focus
The licensing files. Confirm every tracked file under
public/brand/is claimed by exactly one ofLICENSE,ARTWORK-LICENSE.md, orNOTICE.md, and that Faoble's permission is neither broadened nor narrowed from the original wording.