This repository was archived by the owner on Sep 1, 2022. It is now read-only.
feat: migrate countries from types - #212
Merged
Merged
Conversation
jamie-lynch
marked this pull request as draft
June 16, 2021 07:49
jamie-lynch
commented
Jun 16, 2021
jamie-lynch
marked this pull request as ready for review
June 16, 2021 14:35
jamie-lynch
force-pushed
the
migrate-countries
branch
from
June 17, 2021 12:17
ac1942d to
2b39fbb
Compare
sndrs
suggested changes
Jun 17, 2021
jamie-lynch
force-pushed
the
migrate-countries
branch
3 times, most recently
from
June 23, 2021 14:40
214c5d2 to
3a93dbe
Compare
testing the existence of a single pair is enough, so we test against where The Guardian has offices
jamie-lynch
force-pushed
the
migrate-countries
branch
from
June 28, 2021 15:02
3a93dbe to
1221416
Compare
sndrs
previously approved these changes
Jun 28, 2021
sndrs
approved these changes
Jun 28, 2021
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
@guardian/typesto@guardian/libsCountryenum toCountriesByCountryCodeWhy?
See guardian/types#136