Add Feast API scopes for "Saved from web" endpoints#2428
Add Feast API scopes for "Saved from web" endpoints#2428andresilva-guardian wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 840eda5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Tip Once this PR is ready to go, add the This saves us a lot of money by not running the tests before we need them. |
Not entirely sure the packages test suite is broad enough to verify the interaction between DCR <-> @guardian/identity-auth <-> Gateway Might be worth doing a pre-release by adding the "🐥 Canaries" label to this PR, so you can test this change in DCR CODE? I'm not entirely sure how @guardian/identity-auth behaves when a new scope is added, it shouldn't break, but I'm slightly worried about it signing users out who are missing the scope resulting in everyone getting signed out. |
What are you changing?
scopesarray ingetIdentityAuth()in index.ts,guardian.feast-api.saved-from-web.update.selfandguardian.feast-api.saved-from-web.read.self, each with an inline comment explaining what it grants@guardian/identity-auth-frontendWhy?
@guardian/identity-auth-frontend, needs to request access tokens that are valid for the new "Saved from web" endpoints on the Feast API, added in personalised-app-experience#256PUT /v2/saved-from-web/{recipeId}requires theguardian.feast-api.saved-from-web.update.selfscope, andGET /v2/saved-from-web/{recipeId}requires theguardian.feast-api.saved-from-web.read.selfscopescopesarray, consistent with how every other scope in this list is handled today, since this package doesn't support per-feature or per-call scoping