Skip to content

Remove System.Memory dependency on .NET Standard 2.1 in Grpc.Core.Api.#2186

Merged
JamesNK merged 2 commits into
grpc:masterfrom
teo-tsirpanis:patch-1
Jul 20, 2023
Merged

Remove System.Memory dependency on .NET Standard 2.1 in Grpc.Core.Api.#2186
JamesNK merged 2 commits into
grpc:masterfrom
teo-tsirpanis:patch-1

Conversation

@teo-tsirpanis

Copy link
Copy Markdown
Contributor

It's not needed; the types this package provides are inbox.

It's not needed; the types this package provides are inbox.
@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 8, 2023

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: teo-tsirpanis / name: Theodore Tsirpanis (6c6a37f)
  • ✅ login: JamesNK / name: James Newton-King (72bf751)

@JamesNK JamesNK left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other projects have the condition on the ItemGroup. Change PR to be consistent.

Comment thread src/Grpc.Core.Api/Grpc.Core.Api.csproj Outdated
Comment thread src/Grpc.Core.Api/Grpc.Core.Api.csproj Outdated
@JamesNK JamesNK merged commit 6307ca7 into grpc:master Jul 20, 2023
@JamesNK

JamesNK commented Jul 20, 2023

Copy link
Copy Markdown
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants