Fix copying of TMolecule - #1292
Merged
Merged
Conversation
thfroitzheim
reviewed
Jun 8, 2025
| Call init(self, mol0%at, mol0%sym, mol0%xyz, mol0%chrg, mol0%uhf, & | ||
| & mol0%lattice, mol0%pbc) | ||
| self%ftype = mol0%ftype | ||
| end subroutine copyMolecule |
Member
There was a problem hiding this comment.
Maybe we should merge the TMolecule copy part here with the = assignment and add a deep copy of everything. Then one could still just use the assignment with =
thfroitzheim
force-pushed
the
fix/copy
branch
from
November 7, 2025 20:18
f21d134 to
ee8b4f3
Compare
Signed-off-by: Igor S. Gerasimov <foxtranigor@gmail.com>
Signed-off-by: Igor S. Gerasimov <foxtranigor@gmail.com>
Signed-off-by: Igor S. Gerasimov <foxtranigor@gmail.com>
thfroitzheim
force-pushed
the
fix/copy
branch
from
November 7, 2025 22:03
ee8b4f3 to
6285816
Compare
Member
|
@foxtran does this still fix a problem? If yes, I would merge it |
Contributor
Author
|
I would prefer to implement check in LLVM flang firstly to find all problematic places. |
Member
|
#1380 is not fixed by this although it seems related edit: def related to gnu-12, gnu-15 works fine |
TyBalduf
reviewed
Aug 5, 2026
Contributor
thfroitzheim
approved these changes
Sep 11, 2026
thfroitzheim
left a comment
thfroitzheim
left a comment
Member
There was a problem hiding this comment.
Let's use this fix even before merging everything the = assignment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By some reason, GCC 12.2 does not copy some data between TMolecule objects and, therefore, there is some trash in output like (it is xtbopt.xyz):
This patch fixes it. Not sure that I found all places, but at least GFN2 geometry optimizations work well.