This repository was archived by the owner on Nov 29, 2021. It is now read-only.
Queue wait time - #401
Merged
Merged
Conversation
Currently the queue system in ospd prevents to start a new scan if there is not enough available memory. This produces that new scans are put in the queue, while the memory condition is not satisfied. Once some memory is released, all scans in queue are started. In the issue mentioned above, I pasted what I found in the log. This avoids ospd to start many queued scans simultaneously. So the last started scan has time enough to take some memory (launch some child processes).
…queue option It doesn't make sense to wait time if the option is disabled. Also, use global definition for the waiting time in seconds.
Could be possible that there last scan finished in a few seconds. Therefore check for running scans. Although, enough available memory is still a conditional, if enabled.
Codecov Report
@@ Coverage Diff @@
## ospd-20.08 #401 +/- ##
==============================================
+ Coverage 74.41% 74.55% +0.13%
==============================================
Files 23 23
Lines 2627 2641 +14
==============================================
+ Hits 1955 1969 +14
Misses 672 672
Continue to review full report at Codecov.
|
…n is not in the queue anymore
bjoernricks
enabled auto-merge
May 24, 2021 13:26
jjnicola
added
backport-to-stable
ArnoStiefvater
approved these changes
May 26, 2021
This was referenced May 26, 2021
jjnicola
added a commit
that referenced
this pull request
May 26, 2021
Queue wait time (backport #401)
jjnicola
added a commit
that referenced
this pull request
May 26, 2021
jjnicola
added a commit
that referenced
this pull request
May 26, 2021
Queue wait time (backport #401)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Wait a minute between scans starts.
Why:
Currently the queue system in ospd prevents to start a new scan if there is not enough available memory. This produces that new scans are put in the queue, while the memory condition is not satisfied.
Once some memory is released, all scans in queue are started. In the issue mentioned above, I pasted what I found in the log.
How:
Checklist: