This repository was archived by the owner on Nov 29, 2021. It is now read-only.
Always set end_time for interrupted scans. - #353
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## ospd-20.08 #353 +/- ##
==============================================
- Coverage 73.91% 73.90% -0.02%
==============================================
Files 23 23
Lines 2603 2602 -1
==============================================
- Hits 1924 1923 -1
Misses 679 679
Continue to review full report at Codecov.
|
ArnoStiefvater
approved these changes
Jan 26, 2021
bjoernricks
approved these changes
Jan 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Always set end_time for interrupted scans.
Why:
end-time was set via set_scan_status (stopped). Now, the scan can be interrupted directly and the end time will be set.
How:
Interrupt a running scan and check with <get_scans="SCAN-ID"/>that the end_time is set.
Checklist: