This repository was archived by the owner on Nov 29, 2021. It is now read-only.
Return an empty list in case of malformed host in the target list. - #341
Merged
Conversation
This avoid OSPD to crash during calculation of the scan progress.
Codecov Report
@@ Coverage Diff @@
## ospd-20.08 #341 +/- ##
==============================================
+ Coverage 73.44% 73.75% +0.31%
==============================================
Files 23 23
Lines 2576 2576
==============================================
+ Hits 1892 1900 +8
+ Misses 684 676 -8
Continue to review full report at Codecov.
|
ArnoStiefvater
approved these changes
Nov 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Return an empty list in case of malformed host in the target list.
This avoid OSPD to crash during calculation of the scan progress.
Now in conjunction with greenbone/openvas-scanner#625 the scan finishes with errors, but nicely.
Why:
OSPD check the length of the host list during the scan progress calculation. As the target is not empty, but with errors, the scan started but on error it had returned None, which caused ospd to crash.
How:
Start a scan with gvm-cli (gsa already checks for malformed target) wiht 192.168.0.1/32 as host target.
Checklist: