Skip to content
This repository was archived by the owner on Nov 29, 2021. It is now read-only.

Fix convertion from ipv4 range to list of addresses. - #338

Merged
bjoernricks merged 1 commit into
greenbone:ospd-20.08from
jjnicola:ipv4-range
Nov 2, 2020
Merged

Fix convertion from ipv4 range to list of addresses.#338
bjoernricks merged 1 commit into
greenbone:ospd-20.08from
jjnicola:ipv4-range

Conversation

@jjnicola

Copy link
Copy Markdown
Member

What:
For subnet with mask lower than /24, ip addresses ending in .0 are allowed.
This fix add support for ranges including the address ended with .0.

Why:
Because it possible that a host has an IP address ended with .0

How:
Start a scan against the target "10.128.64.0-2"

Checklist:

@jjnicola
jjnicola requested a review from bjoernricks as a code owner October 30, 2020 15:03
@codecov

codecov Bot commented Oct 30, 2020

Copy link
Copy Markdown

Codecov Report

Merging #338 into ospd-20.08 will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@              Coverage Diff               @@
##           ospd-20.08     #338      +/-   ##
==============================================
- Coverage       73.47%   73.44%   -0.03%     
==============================================
  Files              23       23              
  Lines            2571     2576       +5     
==============================================
+ Hits             1889     1892       +3     
- Misses            682      684       +2     
Impacted Files Coverage Δ
ospd/network.py 72.00% <66.66%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c48cbc7...463d6f6. Read the comment docs.

Comment thread ospd/network.py
For subnet with mask lower than /24, ip addresses ending in .0 are allowed.
This fix add support for ranges including the address ended with .0.
@bjoernricks
bjoernricks merged commit a5f5ffe into greenbone:ospd-20.08 Nov 2, 2020
@jjnicola
jjnicola deleted the ipv4-range branch November 2, 2020 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants