This repository was archived by the owner on Nov 29, 2021. It is now read-only.
Start the server before initialize. - #209
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #209 +/- ##
==========================================
- Coverage 73.52% 73.17% -0.35%
==========================================
Files 18 18
Lines 2130 2140 +10
==========================================
Hits 1566 1566
- Misses 564 574 +10
Continue to review full report at Codecov.
|
jjnicola
force-pushed
the
start-server
branch
from
February 18, 2020 15:07
6a6b13b to
8248687
Compare
jjnicola
marked this pull request as ready for review
February 18, 2020 15:12
bjoernricks
suggested changes
Feb 19, 2020
bjoernricks
left a comment
bjoernricks
left a comment
Contributor
There was a problem hiding this comment.
We should only pass the server once to the daemon instance. Therefore I am in favor of changing
daemon.run(server) to daemon.run() only. I've also thought about refactoring the complete initialization process of the daemon but passing the server to init should already provide all necessary use cases.
bjoernricks
reviewed
Feb 19, 2020
This allows to create the socket and give a response to the client, while the server is still in the initialization process.
jjnicola
force-pushed
the
start-server
branch
from
February 19, 2020 12:20
a340333 to
c124f4f
Compare
bjoernricks
suggested changes
Feb 19, 2020
This new method it is the same as misc.remove_pidfile(), but it receives the server too. It will close the server before exiting or during KeyboardInterrupt exception.
Instead of using remove_pidfile().
Was replaced with exit_cleanup(), which closes the server socket too.
bjoernricks
approved these changes
Feb 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to create the socket and give a response to the client, while
the server is still in the initialization process.