Skip to content
This repository was archived by the owner on Nov 29, 2021. It is now read-only.

Only the main process can remove the pid file. - #128

Merged
jjnicola merged 2 commits into
greenbone:masterfrom
jjnicola:del-pid-file
Aug 16, 2019
Merged

Only the main process can remove the pid file.#128
jjnicola merged 2 commits into
greenbone:masterfrom
jjnicola:del-pid-file

Conversation

@jjnicola

Copy link
Copy Markdown
Member

This avoid the pid file to be removed when a child process exits.

This avoid the pid file to be removed when a child process exits.
@jjnicola
jjnicola requested a review from bjoernricks August 16, 2019 09:27
@codecov

codecov Bot commented Aug 16, 2019

Copy link
Copy Markdown

Codecov Report

Merging #128 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
- Coverage   68.74%   68.66%   -0.09%     
==========================================
  Files          12       12              
  Lines        1702     1704       +2     
==========================================
  Hits         1170     1170              
- Misses        532      534       +2
Impacted Files Coverage Δ
ospd/misc.py 74.66% <0%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf0da55...1638dfb. Read the comment docs.

@codecov

codecov Bot commented Aug 16, 2019

Copy link
Copy Markdown

Codecov Report

Merging #128 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
- Coverage   68.74%   68.66%   -0.09%     
==========================================
  Files          12       12              
  Lines        1702     1704       +2     
==========================================
  Hits         1170     1170              
- Misses        532      534       +2
Impacted Files Coverage Δ
ospd/misc.py 74.66% <0%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf0da55...c24809a. Read the comment docs.

@bjoernricks bjoernricks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Path has an open method :-)

Comment thread ospd/misc.py Outdated
Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
@jjnicola
jjnicola requested a review from bjoernricks August 16, 2019 10:07
@jjnicola

Copy link
Copy Markdown
Member Author

I use my administrator privileges to merge this pull request since the change requested/suggested by @bjoernricks was commited.

@jjnicola
jjnicola merged commit 834fd2b into greenbone:master Aug 16, 2019
@jjnicola
jjnicola deleted the del-pid-file branch August 16, 2019 14:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants