Fix for enum type duplication in graphene schema#165
Closed
hoffrocket wants to merge 1 commit into
Closed
Conversation
The converter code was created a new type for each Enum column that it encountered. The problem is where the same Enum type is used for multiple columns. In that case graphene will notice two schema types with the same underlying name and throw an Assertion error like: AssertionError: Found different types with the same name in the schema: pet_kind, pet_kind. This fix creates a new registry dict for storing a type.name to Enum mapping that allows for reuse.
Author
|
I notice that there are some other outstanding PRs that address this issue in addition to some other problems with enums. Any reason those other changes haven't been merged? Would love to find something to address this. Currently have a workaround in place that registers a this solution using @convert_sqlalchemy_type.register(sqlalchemy.types.Enum) |
Collaborator
|
Hi @hoffrocket ! graphene-sqlalchemy maintainer team is now alive ! Could you rebase and resolve conflicts ? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The converter code was created a new type for each Enum column that it
encountered. The problem is where the same Enum type is used for
multiple columns. In that case graphene will notice two schema types
with the same underlying name and throw an Assertion error like:
AssertionError: Found different types with the same name in the schema: pet_kind, pet_kind.
This fix creates a new registry dict for storing a type.name to Enum
mapping that allows for reuse.