Fix Lookup instance filtering - #126
Open
HarshDevelops wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #120
What was wrong
Resolver.Lookupaccepted an instance name, but the internal full servicename was created before that instance was added. Because of that, responses
from other service instances could also be returned.
What changed
Lookup parameters are now created with the instance name from the start, so
responses are filtered to the requested service instance.
The default
localdomain behaviour remains unchanged.Testing
go test ./...could not complete locally because the installed Go 1.26.4toolchain fails linking the repository's older
golang.org/x/netdependency:invalid reference to syscall.recvmsg