Windows: Add support for paths longer than 260 characters - #34
Conversation
* For local paths, we use the `\\?\` prefix * For UNC paths, we use the `\\?\UNC\` prefix * Added a `--long-paths` option to the test app to verify behavior
|
Thanks for the PR. I'll review it soon |
|
Great, thank you for making the changes. I'll merge this PR soon and review your other PRs also. |
|
A general comment, I think we could add tests for those long paths explicitly. |
|
@lacasseio I am a little confused by your comment. The unit tests had explicit long paths tests that were disabled on Windows (see 3c12964), so re-enabling them seems like the natural thing to do when adding support for long paths on that platform. |
|
@rpaquay You are right, my bad for the noise, I should have looked more closely. |
|
@adammurdoch is there still something you are expecting me to change for this particular PR? (I will rebase the others PRs once this one is merged to make them easier to review). |
|
@rpaquay No changes needed. I just need to find some time to test out the changes and merge them. I'll try to do this soon. |
|
Merged, thanks for the PR. |
|
Thanks! |
3 participants
\\?\prefix\\?\UNC\prefix--long-pathsoption to the test app to verify behavior