Add hasFeature function and disallow features.has#4506
Merged
Conversation
The problem with `features.has` is that it takes a string isntead of a `GPUFeatureName`. To prevent typos when checking for features, add a lint warning for `features.has(feature)` and suggest using `hasFeature(features, feature)`. `hasFeature` takes a `GPUFeatureName` and so will warn if the string pass is not a valid feature.
kainino0x
approved these changes
Nov 19, 2025
kainino0x
left a comment
Collaborator
There was a problem hiding this comment.
Nice lint rule, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem with
features.hasis that it takes a string isntead of aGPUFeatureName. To prevent typos when checking for features, add a lint warning forfeatures.has(feature)and suggest usinghasFeature(features, feature).hasFeaturetakes aGPUFeatureNameand so will warn if the string pass is not a valid feature.With this change this issue would have been caught before submission.
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.