Skip to content

Check that createView format is compatible with the view usage.#4495

Merged
Kangz merged 1 commit into
gpuweb:mainfrom
Kangz:createView-usage-inherited
Nov 7, 2025
Merged

Check that createView format is compatible with the view usage.#4495
Kangz merged 1 commit into
gpuweb:mainfrom
Kangz:createView-usage-inherited

Conversation

@Kangz

@Kangz Kangz commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

For example rgba8unorm -> rgba8unorm-srgb prevents using the storage usage on the created view.

Tested against https://dawn-review.googlesource.com/c/dawn/+/270634 that finalize the deprecation in Dawn.

FYI @mwyrzykowski I believe that WebKit doesn't validate this either (it seems it would have been handled around here)


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

For example rgba8unorm -> rgba8unorm-srgb prevents using the storage
usage on the created view.
@Kangz Kangz requested a review from vonture November 7, 2025 11:18
@Kangz Kangz merged commit b05a778 into gpuweb:main Nov 7, 2025
1 check passed
@Kangz Kangz deleted the createView-usage-inherited branch November 7, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants