Skip to content

Refine form control naming and radius in the design library#2994

Merged
qingqing-ux merged 6 commits into
goplus:uifrom
qingqing-ux:feat/input-component-update-pr
Mar 29, 2026
Merged

Refine form control naming and radius in the design library#2994
qingqing-ux merged 6 commits into
goplus:uifrom
qingqing-ux:feat/input-component-update-pr

Conversation

@qingqing-ux

Copy link
Copy Markdown
Collaborator

Summary

  • rename form-style tab components in the design library to semantic Segmented/* names
  • document the design-to-code mapping so form segmented controls map to UITabRadioGroup and UITabRadio
  • unify the design-library radius of form controls to 4px for Segmented, text-input, search, and standard Select variants

Notes

  • this PR is limited to the design library and mapping docs
  • no runtime UI code changes are included in this PR

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive 'Design to Code Mapping Guide' to help developers navigate the relationship between design components in builder-component.lib.pen and their Vue implementations in spx-gui. The guide details mapping rules for various UI elements like buttons, resource cards, and editor panels, while also defining token mappings and practical lookup orders. Review feedback identified several sequential numbering errors in the section headings that need to be corrected to maintain proper document structure.

Comment thread ui/docs/design-to-code-mapping.md Outdated
Comment thread ui/docs/design-to-code-mapping.md Outdated
Comment thread ui/docs/design-to-code-mapping.md Outdated
qingqing-ux and others added 3 commits March 27, 2026 18:07
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Comment thread ui/docs/design-to-code-mapping.md
Comment thread ui/docs/design-to-code-mapping.md
Comment thread ui/docs/design-to-code-mapping.md
Comment thread ui/components/spx/builder-component.lib.pen
Comment thread ui/components/spx/builder-component.lib.pen
@fennoai

fennoai Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Clean, focused PR. The Tab/*Segmented/* rename is complete and consistent, the typo fix (HorizonalHorizontal) is a nice bonus, and the cornerRadius unification to 4px is applied uniformly across all targeted form controls. The new mapping doc is a valuable reference. A few naming consistency and doc accuracy nits are flagged inline.

@qingqing-ux
qingqing-ux enabled auto-merge (squash) March 29, 2026 05:44
@qingqing-ux
qingqing-ux merged commit c441079 into goplus:ui Mar 29, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant