Skip to content

update workflow#2918

Merged
qingqing-ux merged 3 commits into
goplus:uifrom
yueman920:update-workflow
Mar 6, 2026
Merged

update workflow#2918
qingqing-ux merged 3 commits into
goplus:uifrom
yueman920:update-workflow

Conversation

@yueman920

Copy link
Copy Markdown

-update test work flow
-add two images

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@fennoai

fennoai Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

This PR adds a large design file (test workflow.pen, 11,322 lines / ~753 KB), a duplicate GIF (~1 MB), and a duplicate PNG to the repository. The main concerns are: developer machine paths leaked in the .pen file, the file being placed in the wrong directory per the project's own conventions, duplicate binary assets, and a PR title/description that doesn't accurately reflect the changes.

@@ -0,0 +1,11322 @@
{

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Information Disclosure: Developer machine paths committed

Two prompt nodes in this file (IDs XzY6A, jmcI7) contain hardcoded absolute paths from the author's local machine:

/Users/yueman/Desktop/test builder/builder-dev/spx-gui/src/pages/community/home.vue
/Users/yueman/Desktop/test builder/builder-dev/spx-gui/src/components/community/home/banner/GuestBanner.vue
/Users/yueman/Desktop/test builder/builder-dev/spx-gui/src/components/ui/tokens

These are AI-prompt scaffolding nodes captured verbatim when the design tool exported the file. They disclose the author's macOS username and local directory structure and serve no purpose for reviewers. They should be removed before merging.

Comment thread ui/docs/pr-template.md

为了更好地和前端对接,pr需要提交增量,那么提交pr需要分两次commit
- 第一次提交的pencil文件中应该是涉及到改动的原页面模版
- 第二次提交的时候,需要把所有的改动复制到第一次提交的pencil文件中(这一步必须是复制新的改动设计,而不是把文件整个拖进来替换,否则会引起一连串的frame id变更),这样第二次的commit就是干净的代码改动

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline at end of file. The last line (...一起提交) has no trailing newline, which will cause a diff warning on future edits.

@fennoai

fennoai Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

Wrong directory for active design file

ui/archive/ is documented in ui/README.md as "废弃或历史版本设计" (abandoned or historical designs). The test workflow.pen file is clearly new, active work (fresh Unsplash URLs timestamped to March 2026). Per the project's own convention, active feature designs belong under ui/features/spx/<feature-name>_<date>/, consistent with other active designs in the repository (e.g., ui/features/spx/New-version-notification_2026.03.05/).


Duplicate binary assets bloating repository history

  • ui/archive/images/navbar bg.png is byte-for-byte identical to ui/templates/spx/images/navbar bg.png and ui/features/spx/images/navbar bg.png (already committed in prior PRs).
  • ui/templates/spx/images/Notification-2.gif (~1 MB) is byte-for-byte identical to ui/features/spx/images/Notification-2.gif (committed in PR [Template] Update: new version notification #2909).

Neither copy adds anything new. Git history permanently retains all binary blobs, and there is no Git LFS configured. Consider referencing existing assets rather than re-committing them.


PR title/description does not reflect the changes

The title "update workflow" and description "-update test work flow / -add two images" do not accurately describe a PR that adds a 753 KB design file + 1 MB GIF + PNG. Per ui/docs/pr-template.md, the title should use a prefix like [UI] or [Template], and the description should include the linked issue, scope of impact, and a demo.

@qingqing-ux qingqing-ux merged commit 9be29a2 into goplus:ui Mar 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants