update workflow#2918
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
This PR adds a large design file ( |
| @@ -0,0 +1,11322 @@ | |||
| { | |||
There was a problem hiding this comment.
Information Disclosure: Developer machine paths committed
Two prompt nodes in this file (IDs XzY6A, jmcI7) contain hardcoded absolute paths from the author's local machine:
/Users/yueman/Desktop/test builder/builder-dev/spx-gui/src/pages/community/home.vue
/Users/yueman/Desktop/test builder/builder-dev/spx-gui/src/components/community/home/banner/GuestBanner.vue
/Users/yueman/Desktop/test builder/builder-dev/spx-gui/src/components/ui/tokens
These are AI-prompt scaffolding nodes captured verbatim when the design tool exported the file. They disclose the author's macOS username and local directory structure and serve no purpose for reviewers. They should be removed before merging.
|
|
||
| 为了更好地和前端对接,pr需要提交增量,那么提交pr需要分两次commit | ||
| - 第一次提交的pencil文件中应该是涉及到改动的原页面模版 | ||
| - 第二次提交的时候,需要把所有的改动复制到第一次提交的pencil文件中(这一步必须是复制新的改动设计,而不是把文件整个拖进来替换,否则会引起一连串的frame id变更),这样第二次的commit就是干净的代码改动 |
There was a problem hiding this comment.
Missing newline at end of file. The last line (...一起提交) has no trailing newline, which will cause a diff warning on future edits.
|
Wrong directory for active design file
Duplicate binary assets bloating repository history
Neither copy adds anything new. Git history permanently retains all binary blobs, and there is no Git LFS configured. Consider referencing existing assets rather than re-committing them. PR title/description does not reflect the changes The title "update workflow" and description "-update test work flow / -add two images" do not accurately describe a PR that adds a 753 KB design file + 1 MB GIF + PNG. Per |
-update test work flow
-add two images