Repository navigation
fix(web): bundle p-retry into dist/web browser build - #1835
edenbuilds wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
a7c3a41 to
60083da
Compare
|
I have read the CLA Document and I hereby sign the CLA |
|
Hi @edenbuilds, Thank you for your patience. It looks like this branch is currently out-of-date with the base branch. Could you please update the branch to bring it up to date? This will allow us to complete our verification. |
|
Updated the branch to current |
adde65f to
aee1cf5
Compare
|
CLA follow-up: the signed agreement is now recognized and |
|
Hi @edenbuilds, Thank you for your contribution. We have checked the code changes. I will escalate this to the team, and the PR will be reviewed. Thank you for your patience and understanding. |
|
Thanks @Varun-S10. I have refreshed the branch through current
The verified update is pushed at |
b182366 to
911c427
Compare
|
Refreshed the branch onto current upstream |
|
Follow-up on the remaining CLA gate: the current Could the team advise whether the existing CLA can cover that historical author identity, or whether you need a branch-history correction? I have left the published history intact. |
Resolve and inline p-retry for the web target, including its CommonJS package shape, while leaving Node targets externalized. Fixes googleapis#1330
bf30075 to
d98680a
Compare
|
Squashed the branch into a single commit authored as edenbuilds, so |
Summary
@rollup/plugin-node-resolveand no longer marksp-retryas external, sodist/web/index.mjshas no bare"p-retry"specifier.p-retry).Test plan
dist/web/index.mjscontainsfrom 'p-retry'; bundling withp-retryinlined removes that bare import.externalexcludesp-retry; plugins includenode-resolve.Fixes #1330