feat(spanner): implement ToValue for str#6087
Open
fornwall wants to merge 3 commits into
Open
Conversation
ToValue was implemented for &str but not for the unsized str. Callers had to pass an extra reference (&"hello") or allocate a String. Signed-off-by: Fredrik Fornwall <fredrik@fornwall.net>
![gemini-code-assist[bot]](https://avatars.github.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the ToValue trait implementation for string types in the Spanner crate by implementing ToValue directly on str and delegating String and &str to it, alongside adding a new unit test. Feedback suggests using fully qualified path syntax (<str as ToValue>::to_value) in both implementations to avoid intermediate delegation steps, improve readability, and prevent potential infinite recursion from auto-ref coercion.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ToValuewas implemented for&strbut not for the unsizedstr, meaning that callers had to pass an extra reference (&"hello").Fixes #6084.