test(storage): test open_object multiple reads#6079
Open
joshuatants wants to merge 1 commit into
Open
Conversation
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.github.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new transport-level contract test file open_object_grpc.rs to verify the behavior of the open_object gRPC stream under sequential range reads. The review feedback highlights violations of the repository style guide regarding error handling in tests, specifically recommending the replacement of .unwrap() calls with .expect() inside spawned tasks to ensure clearer failure messages.
joshuatants
force-pushed
the
open_object_grpc_tests
branch
from
July 17, 2026 04:27
5f88bb7 to
29f938a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6079 +/- ##
==========================================
- Coverage 97.04% 97.03% -0.01%
==========================================
Files 253 253
Lines 63682 63682
==========================================
- Hits 61798 61795 -3
- Misses 1884 1887 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
joshuatants
marked this pull request as ready for review
July 17, 2026 05:03
coryan
approved these changes
Jul 17, 2026
Contributor
|
FYI, this will merge into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds more tests to help #5991