-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: require protobuf 6.33.5 to address CVE-2026-0994 #17349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ google-api-core>=2 | |
| google-auth>=2 | ||
| grpcio>=1 | ||
| proto-plus>=1 | ||
| protobuf>=6 | ||
| protobuf>=7 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since the minimum supported version of |
||
| {% for package_tuple, package_info in pypi_packages.items() %} | ||
| {# Quick check to make sure `package_info.package_name` is not the package being generated so we don't circularly include this package in its own constraints file. #} | ||
| {% if api.naming.warehouse_package_name != package_info.package_name %} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ google-api-core>=2 | |
| google-auth>=2 | ||
| grpcio>=1 | ||
| proto-plus>=1 | ||
| protobuf>=6 | ||
| protobuf>=7 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since the minimum supported version of |
||
| {% for package_tuple, package_info in pypi_packages.items() %} | ||
| {# Quick check to make sure `package_info.package_name` is not the package being generated so we don't circularly include this package in its own constraints file. #} | ||
| {% if api.naming.warehouse_package_name != package_info.package_name %} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,4 +9,4 @@ google-api-core>=2 | |
| google-auth>=2 | ||
| grpcio>=1 | ||
| proto-plus>=1 | ||
| protobuf>=6 | ||
| protobuf>=7 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,4 +9,4 @@ google-api-core>=2 | |
| google-auth>=2 | ||
| grpcio>=1 | ||
| proto-plus>=1 | ||
| protobuf>=6 | ||
| protobuf>=7 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,5 +9,5 @@ google-api-core>=2 | |
| google-auth>=2 | ||
| grpcio>=1 | ||
| proto-plus>=1 | ||
| protobuf>=6 | ||
| protobuf>=7 | ||
| grpc-google-iam-v1>=0 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,5 +9,5 @@ google-api-core>=2 | |
| google-auth>=2 | ||
| grpcio>=1 | ||
| proto-plus>=1 | ||
| protobuf>=6 | ||
| protobuf>=7 | ||
| grpc-google-iam-v1>=0 | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommending
7.xwhen the minimum supported version is6.33.5(which is6.x) is premature and potentially confusing, as6.xis the current supported major version. It is better to keep the recommendation as6.xso users are guided to a valid, supported version that meets the minimum requirement.