Skip to content

Fixes #4423 - Getter on mutations size#4424

Merged
sduskis merged 4 commits into
googleapis:masterfrom
gremi64:master
Feb 8, 2019
Merged

Fixes #4423 - Getter on mutations size#4424
sduskis merged 4 commits into
googleapis:masterfrom
gremi64:master

Conversation

@gremi64

@gremi64 gremi64 commented Feb 1, 2019

Copy link
Copy Markdown

Allow knowing the size of the list. For exemple, the batch size is limited to 500 mutations

Fixes #4423

Getter over mutations size
Allow knowing the size of the list. For exemple, the batch size is limited to 500 mutations
@gremi64 gremi64 requested a review from a team February 1, 2019 10:53
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Feb 1, 2019
Allow knowing the size of the list. For exemple, the batch size is limited to 500 mutations

Fixes #4423
@gremi64

gremi64 commented Feb 1, 2019

Copy link
Copy Markdown
Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 1, 2019
@ajaaym ajaaym added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2019
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 1, 2019
@gremi64

gremi64 commented Feb 4, 2019

Copy link
Copy Markdown
Author

Hi, i don't understant how it can fail on 2 files i didn't modify (and didn't commit) :
[ERROR] To fix formatting errors, run "mvn com.coveo:fmt-maven-plugin:format"
[ERROR] Non complying file: /tmpfs/src/github/google-cloud-java/google-api-grpc/proto-google-cloud-automl-v1beta1/src/main/java/com/google/cloud/automl/v1beta1/TextClassificationDatasetMetadata.java
[ERROR] Non complying file: /tmpfs/src/github/google-cloud-java/google-api-grpc/proto-google-cloud-automl-v1beta1/src/main/java/com/google/cloud/automl/v1beta1/ImageClassificationDatasetMetadata.java

@gremi64

gremi64 commented Feb 5, 2019

Copy link
Copy Markdown
Author

@ajaaym do i need to modify this two files ? Even if it has nothing to do with my PR

@ajaaym

ajaaym commented Feb 5, 2019

Copy link
Copy Markdown
Contributor

@gremi64 that will be fixed after #4437 is merged.

@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2019
@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 7, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 7, 2019
@sduskis

sduskis commented Feb 7, 2019

Copy link
Copy Markdown
Contributor

@gremi64, it looks like you need to run mvn com.coveo:fmt-maven-plugin:format in order to fix some formatting problems in your code.

@sduskis sduskis added the status: blocked Resolving the issue is dependent on other work. label Feb 7, 2019
@gremi64

gremi64 commented Feb 8, 2019

Copy link
Copy Markdown
Author

@gremi64, it looks like you need to run mvn com.coveo:fmt-maven-plugin:format in order to fix some formatting problems in your code.

It's done :)

@yoshi-automation yoshi-automation added the 🚨 critical P0 critical issue. Requires immediate fix label Feb 8, 2019
@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2019
@sduskis sduskis merged commit 64f3b2b into googleapis:master Feb 8, 2019
@sduskis sduskis removed the status: blocked Resolving the issue is dependent on other work. label Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. 🚨 critical P0 critical issue. Requires immediate fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants