Fluent DSL TableAdmin client by spollapally · Pull Request #3395 · googleapis/google-cloud-java

spollapally · 2018-06-19T20:09:45Z

No description provided.

Sign in to view

+ *         TableAdminRequests.createTable("tableId")
+ *             .addColumnFamily("cf1")
+ *             .addColumnFamily("cf2", GCRULES.maxVersions(10))
+ *             .withGranularity(TimestampGranularity.MILLIS)


Sign in to view

+   *             .rule(GCRULES.maxVersions(10)))
+   *             .drop("mf1")
+   *     client.modifyFamilies(modifyFamiliesReq);
+   *   }


Sign in to view

+ *
+ * <p>Sample code to get started:
+ *
+ * <pre><code>


Sign in to view

+  }
+
+  /**
+   * Creates, Updates and drops ColumnFamilies as per the request See {@link


Sign in to view

+   *             .rule(GCRULES.maxVersions(10)))
+   *             .drop("mf1")
+   *     client.modifyFamiliesAsync(modifyFamiliesReq);
+   *   }


Sign in to view

+     * @return
+     */
+    public ModifyFamilies create(String familyId) {
+      return createWithGCRule(familyId, null);


Sign in to view

+     * @param gcRule
+     * @return
+     */
+    public ModifyFamilies createWithGCRule(String familyId, GCRule gcRule) {


Sign in to view

+     * @param gcRule
+     * @return
+     */
+    public ModifyFamilies updateWithGCRule(String familyId, GCRule gcRule) {


Sign in to view

+   * @param GenerateConsistencyTokenResponse - Protobuf ConsistencyTokenResponse
+   * @return ConsistencyToken - ConsistencyToken response wrapper
+   */
+  public static ConsistencyToken convertTokenResponse(


Sign in to view

+    private Map<String, ClusterState> clusterStates = new HashMap<>();
+    private Map<String, ColumnFamily> columnFamilies = new HashMap<>();
+
+    private Table(com.google.bigtable.admin.v2.Table table) {


spollapally · 2018-06-20T15:50:09Z

Can you please check the latest commit. It should be fixed there.

…

On Wed, Jun 20, 2018 at 11:45 AM, Igor Bernstein ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In google-cloud-clients/google-cloud-bigtable/src/main/java/ com/google/cloud/bigtable/admin/v2/models/TableAdminResponses.java <#3395 (comment)> : > + } + + @OverRide + public String toString() { + return MoreObjects.toStringHelper(this) + .add("tableName", tableName) + .add("timestampGranularity", timestampGranularity) + .add("clusterStates", getClusterStates()) + .add("columnFamiles", getColumnFamiles()) + .toString(); + } + } + + /** Wrapper for ***@***.*** ClusterState} protocol buffer object */ + public static final class ClusterState { + private String id; please fix — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3395 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AfisGFYsBh1tGALGoWPmlXom-mR70kGwks5t-m4EgaJpZM4UuKE1> .

Sign in to view

+   *
+   *     client.createTableAsync(createTableReq);
+   *   }
+   *  }</pre>


Sign in to view

+   *                .union()
+   *                .rule(GCRULES.maxAge(Duration.ofSeconds(100)))
+   *                .rule(GCRULES.maxVersions(1)))
+   *                .createWithGCRule(


Sign in to view

+   *                 .union()
+   *                .rule(GCRULES.maxAge(Duration.ofSeconds(100)))
+   *                .rule(GCRULES.maxVersions(1)))
+   *                .createWithGCRule(


Sign in to view

+    /** Casts the rule to IntersectionRule. On failure throws a ClassCastException */
+    public IntersectionRule getIntersectionOrThow() {
+      return (IntersectionRule) this;
+    }


Sign in to view

+  }
+
+  /** Helpers to support casting rules the Type, when the Type is known */
+  public abstract static class BaseRule implements GCRule {


Sign in to view

+     * @param familyId
+     * @return
+     */
+    public ModifyFamilies create(String familyId) {


Sign in to view

+     *
+     * @return TimestampGranularity
+     */
+    public TimestampGranularity getTimestampGranularity() {


igorbernstein2

LGTM after these changes. @pongad, would you mind reviewing?

Sign in to view

+ * BigtableTableAdminSettings bigtableTableAdminSettings =
+ *   BigtableTableAdminSettings.newBuilder()
+ *   .setCredentialsProvider(FixedCredentialsProvider.create(myCredentials))
+ *     .build();


Sign in to view

+ *   .setCredentialsProvider(FixedCredentialsProvider.create(myCredentials))
+ *     .build();
+ * TableAdminClient client =
+ * TableAdminClient.create(InstanceName.of("[PROJECT]", "[INSTANCE]"), bigtableTableAdminSettings);


Sign in to view

+ * BigtableTableAdminSettings bigtableTableAdminSettings =
+ *     BigtableTableAdminSettings.newBuilder().setEndpoint(myEndpoint).build();
+ * TableAdminClient client =
+ * TableAdminClient.create(InstanceName.of("[PROJECT]", "[INSTANCE]"), bigtableTableAdminSettings);


Sign in to view

+   *  try(TableAdminClient client =  TableAdminClient.create(InstanceName.of("[PROJECT]", "[INSTANCE]"))) {
+   *    CreateTable createTableReq =
+   *      TableAdminRequests.createTable("tableId")
+   *        .addColumnFamily("cf2", GCRULES.maxVersions(10))


Sign in to view

+   * @return ApiFuture<Boolean>
+   */
+  public ApiFuture<Boolean> isConsistentAsync(String tableId, ConsistencyToken token) {
+    ApiFuture<CheckConsistencyResponse> CheckConsResp =


Sign in to view

+
+    /** Gets the configured maximum versions */
+    public int getMaxVersions() {
+      return toProto().getMaxNumVersions();


pongad

I don't know BigTable very well, but nothing looks wrong to me apart from the typo.

@igorbernstein2 could you give an "official" approval?

Sign in to view

+   *
+   * @return DefaultRule
+   */
+  public DefaultRule defaulRule() {


igorbernstein2 · 2018-06-25T19:49:50Z

@pongad thanks for looking.
LGTM after typo fix

formatting.

spollapally requested a review from pongad as a code owner June 19, 2018 20:09

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 19, 2018

igorbernstein2 requested changes Jun 19, 2018

View reviewed changes

spollapally force-pushed the adminclient-table-mv branch from ad80709 to b28ce92 Compare June 20, 2018 07:10

igorbernstein2 reviewed Jun 20, 2018

View reviewed changes

igorbernstein2 mentioned this pull request Jun 20, 2018

Bigtable: Admin should have proto utility methods #3141

Closed

igorbernstein2 reviewed Jun 20, 2018

View reviewed changes

pongad reviewed Jun 25, 2018

View reviewed changes

Comment thread ...s/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/GCRules.java Outdated

*

* @return DefaultRule

*/

public DefaultRule defaulRule() {

This comment was marked as spam.

Sign in to view

igorbernstein2 approved these changes Jun 25, 2018

View reviewed changes

spollapally added 10 commits June 25, 2018 20:12

TableAdmin with Unit tests

8879b66

Add table admin response wrappers, and implement review comments.

c0ddeff

Added documentation

cb17050

Re-formating with googleformatter

4e04909

code review updates.

122f037

More codacy-bot review cleanup

7263049

Refactor method names, remove throwOr methods, and fixed javadocs

a011712

formatting.

Fix failing test case

6a011b1

javadoc indentation fixes.

d530655

defaultRule method name typo fix.

c6a974e

spollapally force-pushed the adminclient-table-mv branch from b79a90b to c6a974e Compare June 26, 2018 00:19

pongad merged commit 675ace7 into googleapis:master Jun 26, 2018

Conversation

spollapally commented Jun 19, 2018

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

spollapally commented Jun 20, 2018 via email

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

igorbernstein2 left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

pongad left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

igorbernstein2 commented Jun 25, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants