partial revert of 578fa27 - #83
Merged
Merged
Conversation
find_package(GTest) does not guarantee the installation of GMock. On systems with only GTest installed, the build will fail due to absence of GMock. There is no reliable way to check for GMock. Hence clone and build googletest while running unit tests Test: ./ultrahdr_unit_test Change-Id: Icd3ecba6debbd7999d15541dd8dc5f451d110909
DichenZhang1
approved these changes
Mar 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find_package(GTest) does not guarantee the installation of GMock. On systems with only GTest installed, the build will fail due to absence of GMock. There is no reliable way to check for GMock. Hence clone and build googletest while running unit tests
Test: ./ultrahdr_unit_test
Change-Id: Icd3ecba6debbd7999d15541dd8dc5f451d110909