Lower C++ constructors and destructors to placement new in inline_cpp! - #1725
Open
copybara-service[bot] wants to merge 1 commit into
Open
Lower C++ constructors and destructors to placement new in inline_cpp!#1725copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_961110735
branch
2 times, most recently
from
August 10, 2026 16:56
ec10ab5 to
6ddf438
Compare
Constructors and destructors in migrated crates are lowered into placement new expressions (`::new (static_cast<void*>(__this)) Type(...)`) and explicit destructor calls (`__this->~Type()`) inside `inline_cpp!` blocks, avoiding separate C-ABI thunk emissions. PiperOrigin-RevId: 961110735
copybara-service
Bot
force-pushed
the
test_961110735
branch
from
August 10, 2026 22:52
6ddf438 to
f2f4fb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lower C++ constructors and destructors to placement new in inline_cpp!
Constructors and destructors in migrated crates are lowered into placement new expressions (
::new (static_cast<void*>(__this)) Type(...)) and explicit destructor calls (__this->~Type()) insideinline_cpp!blocks, avoiding separate C-ABI thunk emissions.