fix: expose Gemini Live API client override#5987
Conversation
|
Response from ADK Triaging Agent Hello @he-yufeng, thank you for creating this PR! Your PR looks great and has successfully been labeled with live. Thank you for associating the issue (#5862), writing thorough unit tests, and including the verification commands in the "Validation" section. To fully satisfy the Contribution Guidelines, could you please update your description to include a quick summary or console output of the passed This will help reviewers understand that all tests are passing successfully and speed up the review process. Thanks! |
|
I have completed a thorough, read-only analysis of Pull Request #5987 to verify its value, architecture alignment, and code quality. The full structured evaluation has been compiled into the following premium artifact:
Key Highlights of Findings
Summary of Work Done
|
|
/adk-pr-analyze |
933060c to
f286222
Compare
|
Updated the branch to cover the mTLS Gemini endpoint in the Live API base URL test as well. This should satisfy the hardcoded googleapis.com check for the changed test file. Validated locally:
Focused model tests passed: 4 passed, 61 deselected. |
|
I have completed a thorough, read-only analysis of Pull Request #5987 to verify its value, architectural alignment, backward compatibility, and code quality. The full structured evaluation has been compiled into the following premium artifact: 📂 analysis_results.md Key Highlights
Summary of Work Done
|
Fixes #5862.
Summary
Geminialready exposesapi_clientas a public override point for normal model calls, but Live API connections still use the private_live_api_clientproperty. That makes regional Vertex AI Live setups depend on overriding a private member even though this is a real extension point.This adds a public
live_api_clientproperty, documents the override pattern, and switchesconnect()to use it. The old_live_api_clientproperty remains as a compatibility alias. Existing subclasses that already override_live_api_clientare still honored by the defaultlive_api_clientimplementation.Validation
Note: my local environment initially had
google-genai==1.65.0; this branch was tested after installing the repository-requiredgoogle-genai>=2.4,<3.