fix: Prevent OkHttp idle threads from blocking JVM shutdown#1268
Open
svetanis wants to merge 1 commit into
Open
fix: Prevent OkHttp idle threads from blocking JVM shutdown#1268svetanis wants to merge 1 commit into
svetanis wants to merge 1 commit into
Conversation
…hutdown This fixes an issue where the JVM hangs waiting for background networking threads to timeout after completing an execution. Replaced default OkHttpClient builders with a new HttpUtils.createSharedHttpClient factory that injects a custom thread factory setting daemon=true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent OkHttp idle threads from blocking JVM shutdown
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
Problem:
The ADK framework does not cleanly terminate the JVM upon process completion when making chat completions requests because
ChatCompletionsHttpClientand the internalGeminiAPI client construct defaultOkHttpClientinstances. These produce non-daemon threads with a keep-alive timeout, keeping the JVM alive.Solution:
Created
HttpUtils.createSharedHttpClient()utility method that returns anOkHttpClientusing a custom dispatcher with a daemon thread factory and 5-minute timeouts. RefactoredChatCompletionsHttpClient,ApiClient, andGeminito invoke this utility and maintain their own shared daemon-thread client pools.Testing Plan
Unit Tests:
All existing core tests pass successfully. (A new test for HttpUtils can be added to verify the ThreadFactory creates daemon threads).
Manual End-to-End (E2E) Tests:
Wired the Google native chat completion client into the external
model-prismproject (PR #1199). Ran the integration through all the demo tests covering all main ADK features. Explicitly tested the native Gemini provider (via thegoogle_search_agenttests) as well as third-party OpenAI-compatible providers. After the final agent response is logged, the Java process successfully exits cleanly with code 0 across all model types instead of hanging while waiting for background threads to timeout.Checklist
Additional context
This fixes critical thread leaks for users running short-lived or background ADK agents.