Skip to content

PSDK-103 adapt BigQuery data source API change#163

Merged
4 commits merged into
gooddata:masterfrom
hkad98:PSDK-103
Oct 27, 2022
Merged

PSDK-103 adapt BigQuery data source API change#163
4 commits merged into
gooddata:masterfrom
hkad98:PSDK-103

Conversation

@hkad98

@hkad98 hkad98 commented Oct 27, 2022

Copy link
Copy Markdown
Contributor
  • adapt BigQuery data source API change
  • minor changes

@ghost

ghost commented Oct 27, 2022

Copy link
Copy Markdown

Build succeeded (check pipeline).

@ghost

ghost commented Oct 27, 2022

Copy link
Copy Markdown

Build succeeded (check pipeline).

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #163 (83c21fd) into master (cf0790c) will decrease coverage by 0.02%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
- Coverage   91.91%   91.88%   -0.03%     
==========================================
  Files          64       65       +1     
  Lines        4191     4214      +23     
==========================================
+ Hits         3852     3872      +20     
- Misses        339      342       +3     
Impacted Files Coverage Δ
gooddata-pandas/gooddata_pandas/good_pandas.py 92.30% <71.42%> (-7.70%) ⬇️
gooddata-sdk/gooddata_sdk/catalog/setting.py 90.47% <88.88%> (-1.20%) ⬇️
gooddata-sdk/gooddata_sdk/catalog/parameter.py 90.90% <90.90%> (ø)
...talog/data_source/declarative_model/data_source.py 99.04% <100.00%> (+0.02%) ⬆️
...dk/catalog/data_source/entity_model/data_source.py 95.91% <100.00%> (+0.72%) ⬆️
...workspace/declarative_model/workspace/workspace.py 99.35% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jaceksan jaceksan added the merge label Oct 27, 2022
@yenkins

yenkins commented Oct 27, 2022

Copy link
Copy Markdown

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-python-sdk-gate-PR163

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Oct 27, 2022
@ghost ghost merged commit 9b9947e into gooddata:master Oct 27, 2022
@ghost

ghost commented Oct 27, 2022

Copy link
Copy Markdown

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants