Skip to content

XSH-837: Allow returning local ids of header labels#158

Merged
1 commit merged into
masterfrom
xsh-837
Oct 10, 2022
Merged

XSH-837: Allow returning local ids of header labels#158
1 commit merged into
masterfrom
xsh-837

Conversation

@torchbear

Copy link
Copy Markdown
Contributor

No description provided.

@ghost

ghost commented Oct 10, 2022

Copy link
Copy Markdown

Build succeeded (check pipeline).

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #158 (20be16d) into master (290de1b) will increase coverage by 0.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   91.51%   91.89%   +0.38%     
==========================================
  Files          74       64      -10     
  Lines        4582     4184     -398     
==========================================
- Hits         4193     3845     -348     
+ Misses        389      339      -50     
Impacted Files Coverage Δ
gooddata-sdk/gooddata_sdk/client.py 91.30% <0.00%> (-8.70%) ⬇️
...ooddata-pandas/gooddata_pandas/result_convertor.py 94.23% <0.00%> (-1.11%) ⬇️
gooddata-sdk/gooddata_sdk/compute/service.py 90.90% <0.00%> (-0.76%) ⬇️
gooddata-sdk/gooddata_sdk/support.py 90.62% <0.00%> (-0.29%) ⬇️
gooddata-sdk/gooddata_sdk/insight.py 77.21% <0.00%> (-0.10%) ⬇️
gooddata-pandas/gooddata_pandas/dataframe.py 100.00% <0.00%> (ø)
...ta_sdk/catalog/workspace/entity_model/workspace.py 96.29% <0.00%> (ø)
...catalog/permission/declarative_model/permission.py 100.00% <0.00%> (ø)
...workspace/declarative_model/workspace/workspace.py 99.35% <0.00%> (ø)
gooddata-pandas/gooddata_pandas/utils.py
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment thread gooddata-pandas/gooddata_pandas/result_convertor.py Outdated
@ghost

ghost commented Oct 10, 2022

Copy link
Copy Markdown

Build succeeded (check pipeline).

Comment thread gooddata-pandas/gooddata_pandas/result_convertor.py Outdated
@ghost

ghost commented Oct 10, 2022

Copy link
Copy Markdown

Build succeeded (check pipeline).

@torchbear

Copy link
Copy Markdown
Contributor Author

ok to test

@ghost

ghost commented Oct 10, 2022

Copy link
Copy Markdown

Build succeeded (check pipeline).

@hkad98 hkad98 self-requested a review October 10, 2022 12:28
@hkad98 hkad98 added the merge label Oct 10, 2022
@yenkins

yenkins commented Oct 10, 2022

Copy link
Copy Markdown

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-python-sdk-gate-PR158

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Oct 10, 2022
@ghost ghost merged commit a88bda5 into master Oct 10, 2022
@ghost

ghost commented Oct 10, 2022

Copy link
Copy Markdown

@hkad98 hkad98 deleted the xsh-837 branch September 6, 2023 11:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants