Skip to content

PSDK-102 no implicit Optional#153

Merged
2 commits merged into
gooddata:masterfrom
hkad98:PSDK-102
Sep 19, 2022
Merged

PSDK-102 no implicit Optional#153
2 commits merged into
gooddata:masterfrom
hkad98:PSDK-102

Conversation

@hkad98

@hkad98 hkad98 commented Sep 19, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@ghost

ghost commented Sep 19, 2022

Copy link
Copy Markdown

Build succeeded (check pipeline).

@hkad98 hkad98 requested a review from pcerny September 19, 2022 09:02
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #153 (c9b8a55) into master (5457830) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #153   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files          74       74           
  Lines        4554     4554           
=======================================
  Hits         4174     4174           
  Misses        380      380           
Impacted Files Coverage Δ
gooddata-pandas/gooddata_pandas/dataframe.py 100.00% <ø> (ø)
...ooddata-pandas/gooddata_pandas/result_convertor.py 95.30% <ø> (ø)
gooddata-pandas/gooddata_pandas/series.py 95.00% <ø> (ø)
gooddata-sdk/gooddata_sdk/compute/model/metric.py 96.18% <ø> (ø)
...talog/data_source/declarative_model/data_source.py 99.01% <100.00%> (ø)
...ta_sdk/catalog/workspace/entity_model/workspace.py 96.29% <100.00%> (ø)
gooddata-sdk/gooddata_sdk/compute/model/filter.py 91.89% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pcerny pcerny added the merge label Sep 19, 2022
@yenkins

yenkins commented Sep 19, 2022

Copy link
Copy Markdown

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-python-sdk-gate-PR153

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Sep 19, 2022
@ghost ghost merged commit 51eba5e into gooddata:master Sep 19, 2022
@ghost

ghost commented Sep 19, 2022

Copy link
Copy Markdown

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants