Skip to content

PSDK-95: Enable schemata parameter in ScanRequest#150

Merged
2 commits merged into
gooddata:masterfrom
jaceksan:working
Sep 14, 2022
Merged

PSDK-95: Enable schemata parameter in ScanRequest#150
2 commits merged into
gooddata:masterfrom
jaceksan:working

Conversation

@jaceksan

Copy link
Copy Markdown
Contributor

No description provided.

@ghost

ghost commented Sep 14, 2022

Copy link
Copy Markdown

Build succeeded (check pipeline).

@ghost

ghost commented Sep 14, 2022

Copy link
Copy Markdown

Build succeeded (check pipeline).

@hkad98

hkad98 commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

Consider replacing create_directory with recreate_directory in every test that performs store. Now you have it only in tests related to workspace content, but it might be beneficial to have it in others.

Also, I thought that we will perform recreate in store class methods.

@ghost

ghost commented Sep 14, 2022

Copy link
Copy Markdown

Build succeeded (check pipeline).

@jaceksan

Copy link
Copy Markdown
Contributor Author

Consider replacing create_directory with recreate_directory in every test that performs store. Now you have it only in tests related to workspace content, but it might be beneficial to have it in others.

Also, I thought that we will perform recreate in store class methods.

@jaceksan jaceksan closed this Sep 14, 2022
@jaceksan jaceksan reopened this Sep 14, 2022
@ghost

ghost commented Sep 14, 2022

Copy link
Copy Markdown

Build succeeded (check pipeline).

@jaceksan

Copy link
Copy Markdown
Contributor Author

Consider replacing create_directory with recreate_directory in every test that performs store. Now you have it only in tests related to workspace content, but it might be beneficial to have it in others.

Also, I thought that we will perform recreate in store class methods.

I updated all tests.
When I updated store methods in SDK, many tests start failing because changed vcr cassette. Leaving it for a follow-up.

@hkad98 hkad98 added the merge label Sep 14, 2022
@yenkins

yenkins commented Sep 14, 2022

Copy link
Copy Markdown

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-python-sdk-gate-PR150

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Sep 14, 2022
@ghost ghost merged commit 81af2d1 into gooddata:master Sep 14, 2022
@ghost

ghost commented Sep 14, 2022

Copy link
Copy Markdown

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants