Skip to content

NAS-4254 manage dependent entities graph#134

Merged
4 commits merged into
gooddata:masterfrom
hkad98:NAS-4254
Aug 18, 2022
Merged

NAS-4254 manage dependent entities graph#134
4 commits merged into
gooddata:masterfrom
hkad98:NAS-4254

Conversation

@hkad98

@hkad98 hkad98 commented Aug 17, 2022

Copy link
Copy Markdown
Contributor

No description provided.

hkad98 added 2 commits August 17, 2022 14:32
* default value set to [] could result in unwanted behaviour therefore I changed it to the safe default using factory
@ghost

ghost commented Aug 17, 2022

Copy link
Copy Markdown

Build succeeded (check pipeline).

Comment thread gooddata-sdk/gooddata_sdk/catalog/base.py Outdated
Comment thread gooddata-sdk/gooddata_sdk/catalog/base.py
Comment thread gooddata-sdk/gooddata_sdk/catalog/base.py
Comment thread gooddata-sdk/gooddata_sdk/catalog/base.py
Comment thread gooddata-sdk/gooddata_sdk/catalog/workspace/entity_model/graph_objects/graph.py Outdated
@ghost

ghost commented Aug 18, 2022

Copy link
Copy Markdown

Build succeeded (check pipeline).

@hkad98 hkad98 requested a review from pcerny August 18, 2022 08:49
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcerny pcerny added the merge label Aug 18, 2022
@yenkins

yenkins commented Aug 18, 2022

Copy link
Copy Markdown

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-python-sdk-gate-PR134

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Aug 18, 2022
@ghost ghost merged commit 0629f59 into gooddata:master Aug 18, 2022
@ghost

ghost commented Aug 18, 2022

Copy link
Copy Markdown

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants