NAS-4024 fix minor inconsistency#114
Merged
1 commit merged intoJun 23, 2022
Merged
Conversation
hkad98
commented
Jun 23, 2022
Contributor
- renamed method in permission service from set_declarative_permissions to put_declarative_permissions to follow the same name convention as other services
- changed input parameter for create_or_update_user and create_or_update_user_group to follow the same convention as other services
|
Build succeeded (check pipeline). |
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
- Coverage 91.81% 91.73% -0.09%
==========================================
Files 69 69
Lines 4156 4161 +5
==========================================
+ Hits 3816 3817 +1
- Misses 340 344 +4
Continue to review full report at Codecov.
|
jaceksan
suggested changes
Jun 23, 2022
* renamed method in permission service from set_declarative_permissions to put_declarative_permissions to follow the same name convention as other services * changed input parameter for create_or_update_user and create_or_update_user_group to follow the same convention as other services
|
Build succeeded (check pipeline). |
jaceksan
approved these changes
Jun 23, 2022
Sonar scan resultMore detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-python-sdk-gate-PR114 To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'. |
|
Build succeeded (gate pipeline).
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.