Skip to content

NAS-4024 fix minor inconsistency#114

Merged
1 commit merged into
gooddata:masterfrom
hkad98:NAS-4024
Jun 23, 2022
Merged

NAS-4024 fix minor inconsistency#114
1 commit merged into
gooddata:masterfrom
hkad98:NAS-4024

Conversation

@hkad98

@hkad98 hkad98 commented Jun 23, 2022

Copy link
Copy Markdown
Contributor
  • renamed method in permission service from set_declarative_permissions to put_declarative_permissions to follow the same name convention as other services
  • changed input parameter for create_or_update_user and create_or_update_user_group to follow the same convention as other services

@ghost

ghost commented Jun 23, 2022

Copy link
Copy Markdown

Build succeeded (check pipeline).

@codecov-commenter

codecov-commenter commented Jun 23, 2022

Copy link
Copy Markdown

Codecov Report

Merging #114 (5638e5a) into master (6494208) will decrease coverage by 0.08%.
The diff coverage is 96.55%.

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage   91.81%   91.73%   -0.09%     
==========================================
  Files          69       69              
  Lines        4156     4161       +5     
==========================================
+ Hits         3816     3817       +1     
- Misses        340      344       +4     
Impacted Files Coverage Δ
...catalog/permission/declarative_model/permission.py 100.00% <ø> (ø)
...sdk/gooddata_sdk/catalog/user/entity_model/user.py 88.13% <85.71%> (-10.08%) ⬇️
gooddata-sdk/gooddata_sdk/__init__.py 100.00% <100.00%> (ø)
...talog/data_source/declarative_model/data_source.py 99.01% <100.00%> (ø)
...ata-sdk/gooddata_sdk/catalog/permission/service.py 100.00% <100.00%> (ø)
...oddata_sdk/catalog/user/entity_model/user_group.py 98.00% <100.00%> (+4.38%) ⬆️
gooddata-sdk/gooddata_sdk/catalog/user/service.py 100.00% <100.00%> (ø)
...workspace/declarative_model/workspace/workspace.py 98.65% <100.00%> (ø)
gooddata-sdk/gooddata_sdk/sdk.py 98.33% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6494208...5638e5a. Read the comment docs.

Comment thread gooddata-sdk/tests/catalog/test_catalog_user_service.py Outdated
Comment thread gooddata-sdk/tests/catalog/test_catalog_user_service.py Outdated
* renamed method in permission service from set_declarative_permissions to put_declarative_permissions to follow  the same name convention as other services
* changed input parameter for create_or_update_user and create_or_update_user_group to follow the same convention as other services
@ghost

ghost commented Jun 23, 2022

Copy link
Copy Markdown

Build succeeded (check pipeline).

@hkad98 hkad98 requested a review from jaceksan June 23, 2022 13:46
@jaceksan jaceksan added the merge label Jun 23, 2022
@yenkins

yenkins commented Jun 23, 2022

Copy link
Copy Markdown

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-python-sdk-gate-PR114

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Jun 23, 2022
@ghost ghost merged commit 403ad5b into gooddata:master Jun 23, 2022
@ghost

ghost commented Jun 23, 2022

Copy link
Copy Markdown

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants