Skip to content

NAS-3893 add permission service#112

Merged
1 commit merged into
gooddata:masterfrom
hkad98:NAS-3893
Jun 22, 2022
Merged

NAS-3893 add permission service#112
1 commit merged into
gooddata:masterfrom
hkad98:NAS-3893

Conversation

@hkad98

@hkad98 hkad98 commented Jun 22, 2022

Copy link
Copy Markdown
Contributor

Added:

  • permission service
  • validation for permission names
  • test support

Added:
* permission service
* validation for permission names
* test support
@ghost

ghost commented Jun 22, 2022

Copy link
Copy Markdown

Build succeeded (check pipeline).

@hkad98 hkad98 requested a review from jaceksan June 22, 2022 09:54
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #112 (0ead7be) into master (1d91ace) will increase coverage by 0.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   91.41%   91.62%   +0.21%     
==========================================
  Files          68       69       +1     
  Lines        4148     4169      +21     
==========================================
+ Hits         3792     3820      +28     
+ Misses        356      349       -7     
Impacted Files Coverage Δ
gooddata-sdk/gooddata_sdk/__init__.py 100.00% <100.00%> (ø)
gooddata-sdk/gooddata_sdk/catalog/base.py 97.22% <100.00%> (+0.44%) ⬆️
...talog/data_source/declarative_model/data_source.py 99.01% <100.00%> (ø)
gooddata-sdk/gooddata_sdk/catalog/identifier.py 94.00% <100.00%> (+6.00%) ⬆️
...atalog/permissions/declarative_model/permission.py 100.00% <100.00%> (ø)
...ta-sdk/gooddata_sdk/catalog/permissions/service.py 100.00% <100.00%> (ø)
...workspace/declarative_model/workspace/workspace.py 98.65% <100.00%> (ø)
gooddata-sdk/gooddata_sdk/sdk.py 98.33% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62d1649...0ead7be. Read the comment docs.

@hkad98 hkad98 added the merge label Jun 22, 2022
@ghost ghost removed the merge label Jun 22, 2022
@ghost

ghost commented Jun 22, 2022

Copy link
Copy Markdown

Build failed (gate pipeline).

@hkad98 hkad98 added the merge label Jun 22, 2022
@ghost ghost removed the merge label Jun 22, 2022
@ghost

ghost commented Jun 22, 2022

Copy link
Copy Markdown

Build failed (gate pipeline).

@jaceksan jaceksan added the merge label Jun 22, 2022
@yenkins

yenkins commented Jun 22, 2022

Copy link
Copy Markdown

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-python-sdk-gate-PR112

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Jun 22, 2022
@ghost ghost merged commit 1913a46 into gooddata:master Jun 22, 2022
@ghost

ghost commented Jun 22, 2022

Copy link
Copy Markdown

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants