Skip to content

NAS-3868 extend user and organisation service #108

Merged
2 commits merged into
gooddata:masterfrom
hkad98:NAS-3868
Jun 2, 2022
Merged

NAS-3868 extend user and organisation service #108
2 commits merged into
gooddata:masterfrom
hkad98:NAS-3868

Conversation

@hkad98

@hkad98 hkad98 commented Jun 1, 2022

Copy link
Copy Markdown
Contributor
  • added method update_oidc_parameters in organization service
  • changed create to create_or_update for users and user groups
  • changed storing users and user groups to layout
  • added test support

@ghost

ghost commented Jun 1, 2022

Copy link
Copy Markdown

Build succeeded (check pipeline).

@hkad98 hkad98 requested a review from pcerny June 1, 2022 09:19
@codecov-commenter

codecov-commenter commented Jun 1, 2022

Copy link
Copy Markdown

Codecov Report

Merging #108 (3947909) into master (86fea2a) will increase coverage by 0.10%.
The diff coverage is 95.90%.

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage   91.20%   91.30%   +0.10%     
==========================================
  Files          68       68              
  Lines        4037     4096      +59     
==========================================
+ Hits         3682     3740      +58     
- Misses        355      356       +1     
Impacted Files Coverage Δ
...oddata_sdk/catalog/user/entity_model/user_group.py 93.61% <89.47%> (-3.16%) ⬇️
.../catalog/organization/entity_model/organization.py 94.28% <93.54%> (+14.28%) ⬆️
...a-sdk/gooddata_sdk/catalog/organization/service.py 95.45% <93.75%> (-4.55%) ⬇️
...ooddata_sdk/catalog/user/declarative_model/user.py 100.00% <100.00%> (ø)
...a_sdk/catalog/user/declarative_model/user_group.py 100.00% <100.00%> (ø)
...sdk/gooddata_sdk/catalog/user/entity_model/user.py 98.21% <100.00%> (+0.34%) ⬆️
gooddata-sdk/gooddata_sdk/catalog/user/service.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86fea2a...3947909. Read the comment docs.

@hkad98 hkad98 requested a review from jaceksan June 1, 2022 09:19
Comment thread gooddata-sdk/tests/catalog/test_catalog_organization.py Outdated
Comment thread gooddata-sdk/gooddata_sdk/catalog/organization/service.py
hkad98 added 2 commits June 2, 2022 15:26
* added method update_oidc_parameters in organization service
* changed create to create_or_update for users and user groups
* changed storing users and user groups to layout
@ghost

ghost commented Jun 2, 2022

Copy link
Copy Markdown

Build succeeded (check pipeline).

@hkad98 hkad98 requested a review from jaceksan June 2, 2022 13:32
@jaceksan jaceksan added the merge label Jun 2, 2022
@yenkins

yenkins commented Jun 2, 2022

Copy link
Copy Markdown

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-python-sdk-gate-PR108

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Jun 2, 2022
@ghost

ghost commented Jun 2, 2022

Copy link
Copy Markdown

@ghost ghost merged commit df4d4a4 into gooddata:master Jun 2, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants