Skip to content

NAS-3276 fixed future warning in GoodPandas#106

Merged
1 commit merged into
gooddata:masterfrom
hkad98:NAS-3276
May 27, 2022
Merged

NAS-3276 fixed future warning in GoodPandas#106
1 commit merged into
gooddata:masterfrom
hkad98:NAS-3276

Conversation

@hkad98

@hkad98 hkad98 commented May 27, 2022

Copy link
Copy Markdown
Contributor
  • set minimum and maximum version for pandas library
  • changed import in utils.py which caused raising FutureWarning

* set minimum and maximum version for pandas library
* changed import in utils.py which caused raising FutureWarning
@ghost

ghost commented May 27, 2022

Copy link
Copy Markdown

Build succeeded (check pipeline).

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #106 (9443af4) into master (6ff3bdd) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   91.20%   91.20%           
=======================================
  Files          68       68           
  Lines        4036     4036           
=======================================
  Hits         3681     3681           
  Misses        355      355           
Impacted Files Coverage Δ
gooddata-pandas/gooddata_pandas/utils.py 87.34% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ff3bdd...9443af4. Read the comment docs.

@hkad98 hkad98 requested review from jaceksan and pcerny May 27, 2022 06:27
@pcerny pcerny added the merge label May 27, 2022
@yenkins

yenkins commented May 27, 2022

Copy link
Copy Markdown

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-python-sdk-gate-PR106

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label May 27, 2022
@ghost ghost merged commit 1990f78 into gooddata:master May 27, 2022
@ghost

ghost commented May 27, 2022

Copy link
Copy Markdown

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants