Skip to content

Adding ACR push #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arschles merged 10 commits into from
Apr 9, 2019
Merged

Adding ACR push #4

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
947a5c7
fixing merge conflict
arschles Apr 8, 2019
4e64d4c
trying without docker login
arschles Apr 8, 2019
6068630
trying az login
arschles Apr 8, 2019
803edd6
doh
arschles Apr 8, 2019
1c79d88
trying login with the managed identity
arschles Apr 8, 2019
1df4ce2
logging in with service principal
arschles Apr 9, 2019
6a131b6
logging in with a service principal properly
arschles Apr 9, 2019
807c774
triggering azure pipelines
arschles Apr 9, 2019
c2fee08
pushing to the right place (I think)
arschles Apr 9, 2019
b01a4b8
fixing var names
arschles Apr 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,25 +12,30 @@ pool:
variables:
imageName: 'athens-win-test:$(build.buildId)'
dockerHubImageName: 'gomods/$(imageName)'
acrImageName: 'gomods/$(imageName)'

acrRegistryName: 'gomods'
acrLoginServer: '$(acrRegistryName).azurecr.io'
acrImageName: '$(acrLoginServer)/$(imageName)'

steps:
- powershell: |
choco install azure-cli
gci 'C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin'
echo "docker build"
docker build --isolation=hyperv -f Dockerfile -t $(imageName) .
echo "dockerhub login"
docker login -u $(dockerHubUsername) -p $(dockerHubPassword)
echo "tag for dockerhub"
docker tag $(imageName) $(dockerHubImageName)
echo "push to dockerhub"
docker push $(dockerHubImageName)
echo "ACR login"
# echo "dockerhub login"
# docker login -u $(dockerHubUsername) -p $(dockerHubPassword)
# echo "tag for dockerhub"
# docker tag $(imageName) $(dockerHubImageName)
# echo "push to dockerhub"
# docker push $(dockerHubImageName)
# echo "done with dockerhub and ACR push"
# for some reason choco install azure-cli does not add the az dir to the PATH
# dir based on https://github.com/Azure/azure-cli/blob/dev/build_scripts/windows/Product.wxs
& "C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin\az.cmd" acr login --name $(acrName)
echo "Azure CLI Login"
& "C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin\az.cmd" login --service-principal -u $(acr-appId) -p $(acr-password) --tenant $(acr-tenant)
echo "ACR login"
& "C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin\az.cmd" acr login --name $(acrRegistryName)
echo "tag for ACR"
docker tag $(imageName) $(acrImageName)
docker push $(acrImageName)
echo "done with dockerhub and ACR push"
docker push $(acrImageName)
echo "done with ACR push"