fix(net/ghttp): normalize method case before route cache lookup#4796
Closed
sonnemusk wants to merge 2 commits into
Closed
fix(net/ghttp): normalize method case before route cache lookup#4796sonnemusk wants to merge 2 commits into
sonnemusk wants to merge 2 commits into
Conversation
serveHandlerKey already upper-cases the method for cache keys, but search used the raw request method. A lowercase "get" miss was therefore stored under "GET:..." and poisoned later real GET requests. Also upper-case Access-Control-Request-Method for OPTIONS preflight. Fixes gogf#4765
Author
|
Closing to keep only high-signal open PRs. Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4765
serveHandlerKeyalready upper-cases the method for cache keys, butgetHandlersWithCacheused the raw request method for search. So a lowercasegetmiss got stored underGET:/pathand later realGETrequests kept hitting that empty cache entry until restart.Change:
strings.ToUpper(r.Method)before search/cacheAccess-Control-Request-Methodon OPTIONSTest:
Test_Router_LowercaseMethodCache(rawhttp.NewRequest("get", ...)then normal GET)